Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Andy Durette
Andy Durette
31,183 Points
Posted by Andy Durette
Andy Durette
31,183 Points

Your setter method is returning the wrong value for the major property.

From what I can gather I am defining the value incorrectly, however I'm not positive on how. insight into what I'm doing wrong would be appreciated.

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

    get major(){
      return this._major; 
    }

    set major(major){
      this._major = major;
      if (this.level === 'Junior' || this.level === 'Senior' ) {
        major = this.level;
      }else if(this.level === 'Freshman' || this.level === 'Sophomore' ){
        major = 'None';
        }  
    }    
}

var student = new Student(3.9, 60);

2 Answers

tomd
tomd
16,701 Points
tomd
tomd
16,701 Points

This is strange, i copied your 'set major' and pasted it into the challenge and it worked. So i copied your whole code and it didn't work. I couldn't find the problem but this seemed to work for me.

set major(major){
      if (this.level === 'Junior' || this.level === 'Senior' ) {
        this._major = major;
      }else if(this.level === 'Freshman' || this.level === 'Sophomore' ){
        this._major = 'None';
        }  
    }
Andy Durette
Andy Durette
31,183 Points
Andy Durette
Andy Durette
31,183 Points

Thanks, I'll take another look at least I know the right answer is in what I wrote now.

Lauren Pinckney
PLUS
Lauren Pinckney
Courses Plus Student 7,229 Points
Lauren Pinckney
Lauren Pinckney
Courses Plus Student 7,229 Points

Your answer appears to be right, but the workspace doesn't like it. Try:

set major(major){ if (this.level === 'Junior' || this.level === 'Senior') { this._major = major; } else { this._major = 'None'; } }

The second conditional is correct, but unnecessary.