Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Anand Rana
Anand Rana
3,898 Points
Posted by Anand Rana
Anand Rana
3,898 Points

why this show return wrong value.

result show wrong value. where i am wrong.

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

  get major()
  {
    return this._major;
  }

  set major(value)
  {
  this._major = value;
    if(value == 'Junior' || value == 'Senior')
    {
      this._major = value;
    }

    else if(value == 'Freshman' || value == 'Sophomore')
    {
      this._major = 'None';
    }
  }

}

var student = new Student(3.9, 60);
student.major = 'Senior';

1 Answer

Steven Parker
Steven Parker
231,184 Points
Steven Parker
Steven Parker
231,184 Points

This code is comparing the argument "value" to the possible level names.

But the argument contains the major to be (potentially) set. To access the level names you need "this.level" instead.