Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialRey Serantes
5,900 PointsWhy is my second letter considered a miss? For example my word is "treehouse" any time I write "r" it counts a miss.
Game file
class Game {
public static final int MAX_MISSES = 7;
private String answer;
private String hits;
private String misses;
public Game(String answer){
this.answer = answer;
hits = "";
misses = "";
}
public boolean applyGuess(char letter){
boolean isHit = answer.indexOf(letter) != 1;
if (isHit) {
hits += letter;
}else{
misses += letter;
}
return isHit;
}
public int getRemainingTries(){
return MAX_MISSES - misses.length();
}
public String getCurrentProgress() {
String progress = "";
for (char letter : answer.toCharArray()){
char display = '-';
if(hits.indexOf(letter) != -1){
display = letter;
}
progress += display;
}
return progress;
}
}
Prompter file
import java.util.Scanner;
class Prompter{
private Game game;
public Prompter(Game game) {
this.game = game;
}
public boolean promptForGuess(){
Scanner scanner = new Scanner(System.in);
System.out.print("Enter a letter: ");
String guessInput = scanner.nextLine();
char guess = guessInput.charAt(0);
return game.applyGuess(guess);
}
public void displayProgress(){
System.out.printf("You have %d tries left to solve: %s%n",
game.getRemainingTries(),
game.getCurrentProgress());
}
}
Hangman file
public class Hangman {
public static void main(String[] args) {
// Your incredible code goes here...
Game game = new Game("snow");
Prompter prompter = new Prompter(game);
while(game.getRemainingTries() > 0){
prompter.displayProgress();
prompter.promptForGuess();
}
}
}
[MOD: edited code blocks -srh]
1 Answer
andren
28,558 PointsBecause of a small but important typo in this line:
boolean isHit = answer.indexOf(letter) != 1;
You are checking that the index is not 1
rather than -1
. This means that you are essentially asking that the index of the letter should not be 1 (which is the second letter) all other indexes will be considered correct, even -1
meaning that currently your program considers incorrect guesses as hits as well.
If you fix that typo you will be get rid of that bug.
Rey Serantes
5,900 PointsRey Serantes
5,900 PointsThat makes sense. It didn't even occur to me that I had missed the -1 instead of having a 1 like I did. Thanks andren