Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Alastair Gray
Alastair Gray
4,659 Points

Why am I getting the following? 'Your setter method is returning the wrong value for the major property.'

'Your setter method is returning the wrong value for the major property.'

Am I not defining my major property correctly?

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    set major(major) {
      this._major = major;

        if(this.level == 'Junior' || this.level == 'Senior') {
        return major;
      } else if(this.level == 'Freshman' ||  this.level == 'Sophmore') {
        return major = 'None';
      }
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
}

var student = new Student(3.9, 60);

2 Answers

Steven Parker
Steven Parker
231,184 Points

Your setter method doesn't need to return anything. But it does need to set the backing variable ("_major") to the correct value in both cases.

Also, you have "Sophmore" (with two "o"s) instead of "Sophomore".

You have two issues:

1) The instructions state 'set the "_major" backing property'. You have used return statements

2) You have misspelled Sophomore