Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Basics Perfecting the Prototype Looping until the value passes

mahesh gurbaxani
mahesh gurbaxani
1,420 Points

where did I go wrong here

where did I go wrong

KnockKnock.java
/*  So the age old knock knock joke goes like this:

    Person A:  Knock Knock.
    Person B:  Who's there?
    Person A:  Banana
    Person B:  Banana who?
    ...as long as Person A has answered Banana the above repeats endlessly
    ...assuming the person answers Orange we'd see
    Person B:  Orange who?
    ...and then the punchline.
    Person A:  Orange you glad I didn't say Banana again?
    (It's a really bad joke that makes it sound like "Aren't you glad I didn't say Banana again?")

    Let's just assume the only two words passed in from the console from Person B are either banana or orange.
*/

// ====BEGIN PROMPTING CODE====

// Person A asks:
console.printf("Knock Knock.\n");

// Person B asks and Person A's response is stored in the String who:
String who = console.readLine("Who's there?  ");

// Person B responds:
console.printf("%s who?\n", who);
do
{
   if(who.equals("banana"))
   {console.printf("banana who");
                   } ||
    if(who.equals("orange"))
                   {console.print("orange you glad i'm not another banana?");
                   }
   while (who.equals("banana")||who.equals("orange"));

2 Answers

The loop needs to do something, while a specific condition exists. While the input is "banana" it should prompt fot the surname.

String who;

do {
   console.printf("Knock Knock.\n");
   who = console.readLine("Who's there? ");  
   console.printf("%s who?\n", who);
} while (who.equalsIgnoreCase("banana"));

if(who.equals("orange"))
                   {console.print("orange you glad i'm not another banana?");
                   }

please notify me if this helps

Sharina V. Jones
Sharina V. Jones
11,459 Points

You've created an endless loop. Since there is no prompt in your do...while statement to change the value of who, it will always be "orange" or "banana". You need to prompt the user again in the body of the do...while loop.