Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialAndre Kucharzyk
4,479 PointsWhats wrong with my code?
in second objective of 'applying the discount code' I get error message: "Oops it looks like task 1 is no longer passing. Why?
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
private String normalizeDiscountCode(String discountCode) {
if (!discountCode.matches("[a-zA-Z]") && discountCode != "$") {
throw new IllegalArgumentException("Invalid discount code");
}
return discountCode.toUpperCase();
}
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
2 Answers
Steve Hunter
57,712 PointsHi there,
You are comparing the entire discount code to a character. That's not gonna work!
discountCode != "$"
The use of the regex is good, but you either need to include the $
in you regex, or test each character individually within a for
loop. Maybe use the Character.isLetter()
class method as well as != '$'
.
I've written lots of posts answering this particular challenge - it catches many people out as it's a good test.
Let me know you get on.
Steve.
Andre Kucharzyk
4,479 PointsWell, that is pretty obvious to me after I've read your message. I fail to see how I didn't see it before.
Thank you for your time, Steve.
Steve Hunter
57,712 PointsHey, no problem!