Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Creating the MVP Counting Scrabble Tiles

Posted by priyanka shukla
priyanka shukla
3,051 Points

what is wrong with my code i think i have written how it has asked

it says to compare letter with tiles i have done same just used the word check why its telling wrong?

ScrabblePlayer.java 
public class ScrabblePlayer {
  // A String representing all of the tiles that this player has
  private String tiles;

  public ScrabblePlayer() {
    tiles = "";
  }

  public String getTiles() {
    return tiles;
  }

  public void addTile(char tile) {
    tiles += tile;
  }

  public boolean hasTile(char tile) {
    return tiles.indexOf(tile) != -1;
  }

  public int getCountOfLetter(char letter)
  { int count=0;
    for (char check:tiles.toCharArray())
    { if (tiles.indexOf(check)!=-1)
      {count+=1;}
      }
    return count;

  }

}
Example.java 
// This code is here for example purposes only
public class Example {

  public static void main(String[] args) {
    ScrabblePlayer player1 = new ScrabblePlayer();
    player1.addTile('d');
    player1.addTile('d');
    player1.addTile('p');
    player1.addTile('e');
    player1.addTile('l');
    player1.addTile('u');

    ScrabblePlayer player2 = new ScrabblePlayer();
    player2.addTile('z');
    player2.addTile('z');
    player2.addTile('y');
    player2.addTile('f');
    player2.addTile('u');
    player2.addTile('z');

    int count = 0;
    // This would set count to 1 because player1 has 1 'p' tile in her collection of tiles
    count = player1.getCountOfLetter('p');
    // This would set count to 2 because player1 has 2 'd'' tiles in her collection of tiles
    count = player1.getCountOfLetter('d');
    // This would set 0, because there isn't an 'a' tile in player1's tiles
    count = player1.getCountOfLetter('a');

    // This will return 3 because player2 has 3 'z' tiles in his collection of tiles
    count = player2.getCountOfLetter('z');
    // This will return 1 because player2 has 1 'f' tiles in his collection of tiles
    count = player2.getCountOfLetter('f');
  }
}

2 Answers

Yanuar Prakoso
Yanuar Prakoso
15,196 Points
Yanuar Prakoso
Yanuar Prakoso
15,196 Points

Hi there

You need to revise the code that I put comment on:

public int getCountOfLetter(char letter)
  { int count=0;
    for (char check:tiles.toCharArray())
    { if (tiles.indexOf(check)!=-1)//<-- this is wrong
      {count+=1;}
      }
    return count;

  }

Basically what you've done here is comparing character object called check which is part of String called tiles. Therefore your if statement will always return True and the counter will only count how much characters are there in the String tiles. This is not what the challenge want, as you said it wants you to check how many characters inside String tiles matches the character called letter. Thus this is how you should do it:

public int getCountOfLetter(char letter){
    int counter = 0;
    for(char tile : tiles.toCharArray()){
      if(tile == letter){
        counter++;
      }
    }
    return counter;
  }

I hope this can help you a little.

Pieter-Andries van der Berg
Pieter-Andries van der Berg
7,468 Points
Pieter-Andries van der Berg
Pieter-Andries van der Berg
7,468 Points

i found the challenges hard to come up with xd

thanks for explaining it though