Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

welsen ho
welsen ho
1,330 Points
Posted by welsen ho
welsen ho
1,330 Points

what is wrong with my code?

I keep trying for a lot of methods, but still can't solve, can someone help me see? thanks in advanced!!!

Order.java 
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = discountCode;
  }

  private String nomalizeDiscountCode(){


    char[] upper = discountCode.toCharArray();
    String uppperDiscountCode = Character.toUpperCase(upper[discountCode]);
    return upperDiscountCode;
  }
}
Example.java 
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Dave Harker
PLUS
Dave Harker
Courses Plus Student 15,510 Points
Dave Harker
Dave Harker
Courses Plus Student 15,510 Points

Hi Welsen Ho,

You're getting there. A few minor tweaks ...

  public void applyDiscountCode(String discountCode) {
    // should be assigning the return value from nomalizeDiscountCode here as per task requirement
    this.discountCode = discountCode;
  }

  private String nomalizeDiscountCode(){ // What is getting passed in?
    // OK, could be done within the loop condition but nothing wrong with defining first
    char[] upper = discountCode.toCharArray(); 

    // need a loop here to go through the charArray 
        // and if here checking each element of charAarray for isLetter() or '$'
            // throw the IllegalArgumentException here with message here if check fails
    // close loop

    // not required - just delete this line (see why in next comment)
    String uppperDiscountCode = Character.toUpperCase(upper[discountCode]); 

    // no need to complicate this, if you've made it here just return the original 
    // passed string value with toUpperCase() tacked on (all in one return)
    return upperDiscountCode;
  }

Hope this helps you out :dizzy:
Dave