Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialRemco de Wilde
9,864 PointsWhat am i doing wrong? normalize Discount Code in Java Objects
Don't understand this, I check for letter and $.
Hmmm...I ran order.applyDiscountCode("h1!") and I expected it to throw an IllegalArgumentExcept
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
private String normalizeDiscountCode (String discountCode){
this.discountCode=discountCode.toUpperCase();
for (char letter : discountCode.toCharArray()){
if(!Character.isLetter(letter)|| letter != '$' ){
throw new IllegalArgumentException ("Invalid discount code");
}
}
return discountCode;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
try{
discountCode=normalizeDiscountCode(discountCode) ;
}catch (IllegalArgumentException iae){
//do something
}
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
3 Answers
Remco de Wilde
9,864 PointsChanged code to my first version always throws exception because !$ is always true as long as there is no $:
private String normalizeDiscountCode (String discountCode){
this.discountCode=discountCode.toUpperCase();
for (char letter : discountCode.toCharArray()){
if(! Character.isLetter(letter) && letter != '$' ){
throw new IllegalArgumentException ("Invalid discount code");
}
}
return discountCode;
}
first run
h gives ! letter = false and not $ true no exeption
Second run
1 gives ! letter = true and not $ true must give exexption so what is wrong with my reasoning.
Remco de Wilde
9,864 PointsThe problem was the try, catch, removing them solved the problem, i did this some days ago, but forgot to post the solution here.
Arcee Palabrica
8,100 PointsYour code seems fine... my question though is in your applyDiscountCode() method... Your try-catch block is already in the example.java file.
Wagner Melo
2,121 PointsWagner Melo
2,121 PointsTks Remco, I was also using ||