Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Design

Web portfolio critique (was meant for Treehouse Designer opening)

Well shoot! I was planning on applying for the Designer opening at Treehouse. I noticed the position a few weeks ago and put together this portfolio site: http://www.jakerorrer.com. Just noticed today the position is gone! AAaaahhhh.... oh well, I'll be ready for next time, right?

I was still planning on adding an animation and had a couple other things to do like concatenating and minifying my files. My background is an IT project manager, but I have been learning design of all types over the last couple years thanks to Treehouse, Karen X Cheng and many others.

I guess I will have to settle for a design critique for now... Any feedback provided is much appreciated and many thanks to anyone who takes the time to check my site out! Finally, a huge THANK YOU to Treehouse employees, without whom this site would not be possible!

All the best, Jake

EDIT: Wow, glad I just checked the job board! The opening is back up again - hoping I can apply sometime tonight!

6 Answers

Hey Kyle, thanks man!

Darren Healy
seal-mask
.a{fill-rule:evenodd;}techdegree
Darren Healy
Front End Web Development Techdegree Student 23,565 Points

Really like it Jake, well done.

Can I just ask while I'm here, how do you enable the cool 'jump to content' (for lack of a better description - what is this actually called?) function when you click on the links in your navigation?

Thanks a lot, Darren! I used quite a bit of jquery on my nav bar... what I think you are referring to is smooth scrolling or jQuery smooth scrolling when clicking an anchor/internal link, and CSS Tricks has an article on it here: http://css-tricks.com/snippets/jquery/smooth-scrolling/. There is also lots of other information on getting this effect on stackoverflow and other sites if you do a Google search. It is really just a jQuery scroll animation on the nav link click event.

I also had a couple other cool jQuery features on the navigation if you're interested. One is shrinking the header as you start to scroll down:

//Shrink main header when scrolling down
$(window).scroll(function() {
    var windscroll = $(window).scrollTop();
    if (windscroll >= 138) {
        $('.main-header').addClass('shrink-header');
    } else {
        $('.main-header').removeClass('shrink-header');
    }
}).scroll();

Another is changing the active link as you reach a new section when scrolling down (i.e. when you reach the About section, the About link becomes active/bold):

//Change active link based on scroll position
$(window).scroll(function() {
    var windscroll = $(window).scrollTop();
    if (windscroll >= 138) {
        $('h1[id$="section"]').each(function(i) {
            var offset = $(this).offset();
            // console.log(offset, offset.top, windscroll+1);
            if (offset.top <= windscroll + 1) {
                $('.selected').removeClass('selected');
                $('.main-nav ul li a').eq(i).addClass('selected');
            }
        });
    } else {
        $('.selected').removeClass('selected');
        $('.main-nav ul li a:first').addClass('selected');
    }
}).scroll();

Changing the active link when scrolling down was tough... I tried using jQuery's position method initially, but it actually didn't work in webkit browsers... offset is what did the trick though. Where you see windscroll + 1, that was just me trying to get the positioning just right when scrolling.

Darren, I hope this helps, and thanks again for the feedback!

Darren Healy
seal-mask
.a{fill-rule:evenodd;}techdegree
Darren Healy
Front End Web Development Techdegree Student 23,565 Points

Thanks Jake, JavaScript and jQuery are a little beyond me at this stage, but this is a good reference for me to come back to for sure!

Good deal, glad I could help Darren! If you know CSS, then I would suggest picking up jQuery first because it's syntax uses a lot of the same CSS selectors... that definitely helped me A LOT when picking it up at first.

Does anyone out there have critical feedback? I am open to feedback of all kinds... logo design, web/mobile design, portfolio, coding, etc. Thanks in advance!

This is a great looking portfolio site, Jake! My background is in graphic design so I was hoping to provide you with some tips for design but it looks outstanding! I really like the two fonts you paired together and color scheme. Overall a well balanced and intriguing website.

P.S. like the logo! Being a person who also has a J for a first initial, I have found it to be a difficult letter to incorporate in a monogram logo.

Best of luck!

Hey Josiah Dawley, thank you so much! I have definitely been learning about design theory and principles over the last couple years outside of Treehouse, and I tried to incorporate a lot of that learning into my site as well - I'm glad you noticed man!

About the logo, I was mulling around with several different designs before finally settling on that one. It definitely is hard to incorporate J's for some reason! My middle initial is actually D for Douglas, and I tried some designs incorporating an uppercase D as the dot for the J trying to get all the initials in there. It looked good with some designs I came up with, but not really with the script typeface I chose for my final logo unfortunately.

Josiah, I really appreciate the feedback and thanks again!

James Barnett
James Barnett
39,199 Points

It's a nicely done site, good use of CSS & JavaScript skills also nice use of color, type, illustrations.

However, I think the text layout kills the whole design. Giant blocks of text generally aren't a good idea. I'm also not a fan of the line lengths.

Hey James Barnett, thanks for the feedback! After taking a second look, I agree with you about the text layout to some extent, especially in the About section and the section prior to that where there is lots of text... What would you recommend for the text layout? Multi-column layout, additional illustrations to break it up, less copy or something else? Also, what do you think is wrong with the line lengths? They are on the shorter end of the recommended 45-75 characters per line (I think they are around 55-60 or so), but they look good to me.

Thanks again for checking out my site. I appreciate it, sir!