Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Nina Tanzia
Nina Tanzia
1,755 Points

Unsure of where the bug is...

I have looked over the code and cannot seem to find the error. What am I not noticing?

Thank you in advance!

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

private String normalizeDiscountCode (String discountCode)
{
  for( char l: discountCode.toCharArray())
{
if (l != '$')
{throw new IllegalArgumentException("Invalid discount code.");}
}
return discountCode.toUpperCase();
}

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode( discountCode);
  }




}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Alex Bratkovskij
Alex Bratkovskij
5,329 Points

Heya Nina,

The task asks you to check if discountCode starts with '$' or if its a string of only letters. by the code you provided, it checks each if each character is not '$' and if it is not, then it throw IllegalArgumentException

-Alex

Nina Tanzia
Nina Tanzia
1,755 Points

Hello Alex, Thank you for identifying my error. It seems like I got lost while reading my own code and did not notice this detail! I went ahead and added the second condition and my code ran without any errors.

Thanks again!