Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by Daniel Corio-Rosas
Daniel Corio-Rosas
6,995 Points

unexpected string

Not sure what I'm missing?

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

     set major(major){
       this._major= major;
       if(this.level=== 'Senior'|| this.level==='Junior'){
         return this._major;
       }else if(this.level=== 'Freshmen' || this.level'Sophomore'){
         return 'None';
        }
     }

}

var student = new Student(3.9, 60);

1 Answer

tako izu
tako izu
17,645 Points
tako izu
tako izu
17,645 Points

You appear to be missing a '===' equal operation between this.level and 'Sophomore'.

Fixed code below:

class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

     set major(major){
       this._major= major;
       if(this.level==='Senior' || this.level==='Junior'){
         return this._major;
       }else if(this.level==='Freshmen' || this.level==='Sophomore'){
         return 'None';
        }
     }

}

var student = new Student(3.9, 60);
Daniel Corio-Rosas
Daniel Corio-Rosas
6,995 Points

thanks bro