Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialMike Zammit
1,813 PointsTrouble with Code Challenge: Applying a Discount Code
I'm trying to complete this code challenge, the first task completes fine, but the second keeps coming up and telling me that my first task doesn't run anymore. When I go back and click on the error, it's the exception the 2nd task has asked me to create.
See my code attached, but I've used the Character.toCharArray() method to convert the string into chars, and then used an if statement to check each using the .isLetter() method or != '$'. Am I doing something wrong here?
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
private String normalizeDiscountCode(String discountCode) {
for (char symbol : discountCode.toCharArray()) {
if (! Character.isLetter(symbol) || symbol != '$') {
throw new IllegalArgumentException("Invalid discount code");
}
}
return discountCode.toUpperCase();
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
1 Answer
Mike Zammit
1,813 PointsI've figured it out. In this section:
private String normalizeDiscountCode(String discountCode) { for (char symbol : discountCode.toCharArray()) { if (! Character.isLetter(symbol) || symbol != '$') { throw new IllegalArgumentException("Invalid discount code"); }
The if statement should be looking for &&, not ||