Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

adil rafaa
adil rafaa
3,194 Points

The editor crashes when I tried to pass Task 2

Hello ! Can you someone explain to me why my code is crashing , it said something about the illegal exception

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  private String normalizeDiscountCode(String discountCode){
    char c = '$';
    for (char letter : discountCode.toCharArray()){

             if( (!(Character.isLetter(letter))) ||  (Character.getType(letter) != c) ) {
                    throw new IllegalArgumentException( letter + "Invalid letter pr symbole ");
             } 
    } 
    return discountCode.toUpperCase();
  }


  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

3 Answers

Hi

Try

if (!Character.isLetter(letter) && letter != '$')

what you have Character.getType(letter) returns the ASSCI numeric value of the char you are passing ... in this case, the value of c.

If this answers your question, please mark the question as answered.

Thanks

Hi

it crashing because your are throwing an exception and not handling it

        if( (!(Character.isLetter(letter))) ||  (Character.getType(letter) != c) ) {
            throw new IllegalArgumentException( letter + "Invalid letter pr symbole ");
        }

your discount code is abc

you are grabbing the first letter which is letter 'a'

!(Character.isLetter(letter))) =====> false

II

(Character.getType(letter) != c) ======> true

false || true =======> true

hence, you are throwing an exeption

please try replacing || with &&

if this answers your question, please mark the question as answered.

Thanks

adil rafaa
adil rafaa
3,194 Points

Thanks for the quick answer, now my code is not crashing anymore ,however , still give me issues even when i tried

  if( (!(Character.isLetter(letter))) && ( (Character.getType(letter) != c) )) {

I'm sure something is not right in this part : (Character.getType(letter) != c) )

adil rafaa
adil rafaa
3,194 Points

Thanks a a lot Mark