Teamwork challenge is a beast ...

Question

Hey folks, con someone help me with this ???

The error is:

Type a word for: name
Type a word for: adjective
Type a word for: noun
Be nice, dork is not allowed here 
Be nice, dweeb is not allowed here 
Type a word for: noun
java.lang.NullPointerException
    at com.teamtreehouse.Prompter.promptForWord(Prompter.java:65)
    at com.teamtreehouse.Prompter.promptForWords(Prompter.java:54)
    at com.teamtreehouse.Prompter.run(Prompter.java:41)
    at com.teamtreehouse.Main.main(Main.java:15)
    at JavaTester.run(JavaTester.java:77)
    at JavaTester.main(JavaTester.java:39)

com/teamtreehouse/Main.java

package com.teamtreehouse;

import java.io.IOException;
import java.util.Arrays;
import java.util.List;

public class Main {

    public static void main(String[] args)  {

        Prompter prompter = new Prompter();
        String story = "Thanks __name__ for helping me out.  " +
        " You are really a __adjective__ __noun__ and I owe you a __noun__.";
        Template tmpl = new Template(story);
        prompter.run(tmpl);
    }
}

com/teamtreehouse/Prompter.java

package com.teamtreehouse;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Set;


public class Prompter {
    private BufferedReader mReader;
    private Set<String> mCensoredWords;

    public Prompter() {
        mReader = new BufferedReader(new InputStreamReader(System.in));
        loadCensoredWords();
    }

    private void loadCensoredWords() {
        mCensoredWords = new HashSet<String>();
        Path file = Paths.get("resources", "censored_words.txt");
        List<String> words = null;
        try {
            words = Files.readAllLines(file);
        } catch (IOException e) {
            System.out.println("Couldn't load censored words");
            e.printStackTrace();
        }
        mCensoredWords.addAll(words);
    }

    public void run(Template tmpl) {
        List<String> results = null;
        try {
            results = promptForWords(tmpl);
        } catch (IOException e) {
            System.out.println("There was a problem prompting for words");
            e.printStackTrace();
            System.exit(0);
        }
        String renderedResults = tmpl.render(results);
        System.out.println(renderedResults);
    }

    public List<String> promptForWords(Template tmpl) throws IOException {
        List<String> words = new ArrayList<String>();
        for (String phrase : tmpl.getPlaceHolders()) {
            String word = promptForWord(phrase);
            words.add(word);
        }
        return words;
    }


    public String promptForWord(String phrase) throws IOException {
        System.out.printf("Type a word for: %s\n", phrase);
        String wordFromUser = mReader.readLine();

        while (mCensoredWords.contains(wordFromUser.toLowerCase())) {
            System.out.printf("Be nice, %s is not allowed here \n", wordFromUser);
            wordFromUser = mReader.readLine();
        }
        return wordFromUser.trim();
    }
}

pseudo-tests.md

#  This is essentially what I am testing 
1.  The user is prompted for a new string template (the one with the double underscores in it).

  a. The prompter class has a new method that prompts for the story template, and that method is called.

2.  The user is then prompted for each word that has been double underscored.

   a. The answer is checked to see if it is contained in the censored words.
      User is continually prompted until they enter a valid word

3.  The user is presented with the completed story

Answer 1 · 2016-01-18T05:52:14Z

January 18, 2016 5:52am

Your IDE is spitting out a bunch of null pointer exception errors which means it's looking for stuff that's not there. Either the feeding or the eating mechanism is broken, so analyzing further...

I see that you're doing prompter.run() on a single story String.

String story = "Thanks __name__ for helping me out. " +  
                        "You are really a __adjective__ __noun__ and I owe you a __noun__.";
Template tmpl = new Template(story);
    prompter.run(tmpl);

Therefore, I think you need to feed it more story Strings. Try doing something like this:

//Main Class

package com.teamtreehouse;

import java.io.BufferedReader; import java.io.InputStreamReader;

public class Main {
public static void main(String[] args) {
    // write your code here
    Prompter prompter = new Prompter();
    BufferedReader yesNoReader = new BufferedReader(new InputStreamReader(System.in));
    String story = "Thanks __name__ for helping me out.  You are really a __adjective__ __noun__ and I owe you a __noun__.";
    Template tmpl = new Template(story);
    prompter.run(tmpl);
}
}

And then...

//Prompter Class

package com.teamtreehouse;

import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.nio.file.Files; import java.nio.file.Path; import java.nio.file.Paths; import java.util.ArrayList; import java.util.HashSet; import java.util.List; import java.util.Set;

public class Prompter { private BufferedReader mReader; private Set mCensoredWords;

public Prompter() {
    mReader = new BufferedReader(new InputStreamReader(System.in));
    loadCensoredWords();
}

private void loadCensoredWords() {
    mCensoredWords = new HashSet<String>();
    Path file = Paths.get("resources", "censored_words.txt");
    List<String> words = null;
    try {
        words = Files.readAllLines(file);
    } catch (IOException e) {
        System.out.println("Couldn't load censored words");
        e.printStackTrace();
    }
    mCensoredWords.addAll(words);
}

public void run(Template tmpl) {
    List<String> results = null;
    String response = null;

    do {

        try {
            results = promptForWords(tmpl);
        } catch (IOException e) {
            System.out.println("There was a problem prompting for words");
            e.printStackTrace();
            System.exit(0);
        }
        //Print out the results that were gathered here by rendering the template
        System.out.printf("Your TreeStory:%n%n%s", tmpl.render(results));
        //See if player would like another go
        System.out.println("\n\nWould you like to try again?  ");
        try {
            response = mReader.readLine();
            if (response == null) {
                response = "no";
            }
        } catch (IOException e) {
            System.out.println("There was a problem with your answer.");
            e.printStackTrace();
            System.exit(0);
        }

    } while (response.compareToIgnoreCase("yes") == 0);

}

/**
 * Prompts user for each of the blanks
 *
 * @param tmpl The compiled template
 * @return
 * @throws IOException
 */
public List<String> promptForWords(Template tmpl) throws IOException {
    List<String> words = new ArrayList<String>();
    for (String phrase : tmpl.getPlaceHolders()) {
        String word = promptForWord(phrase);
        words.add(word);
    }
    return words;
}


/**
 * Prompts the user for the answer to the fill in the blank.  Value is guaranteed to be not in the censored words list.
 *
 * @param phrase The word that the user should be prompted.  eg: adjective, proper noun, name
 * @return What the user responded
 */
public String promptForWord(String phrase) throws IOException {

    String response = null;
    do {
        System.out.printf("Please give me a %s:  ", phrase);
        response = mReader.readLine();
        if (response == null) {
            response = "no";
        }
    } while (mCensoredWords.contains(response));

    return response;
}
}

Any errors with this?

Welcome to the Treehouse Community

Looking to learn something new?

Grigorij Schleifer

Grigorij Schleifer

Teamwork challenge is a beast ...

Andrew Winkler

Andrew Winkler

Grigorij Schleifer

Grigorij Schleifer

1 Answer

Andrew Winkler

Andrew Winkler