Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Task 1 no longer passing

I dont understand this error: task 1 no longer passing. Is about the return´s values? Or i am missing something?

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  private String normalizeDiscountCode(String discountCode) {
      for (char letter : discountCode.toCharArray())
      {
         if ((! Character.isLetter(letter)) || (letter != '$'))
      {
        throw new IllegalArgumentException("Invalid discount code.");
      } 
      }  
            return discountCode.toUpperCase(); 
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
   this.discountCode = normalizeDiscountCode(discountCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

andren
andren
28,558 Points

The error originates from the fact that your code results in an exception being thrown, when the code checker tries to verify that your code still responds as expected when it provides the test input that it provided in task 1.

The reason for this is a logic error in your if statement, with the way it is written any input it receives (including valid characters) will cause it to run and therefore throw an exception. I'd suggest taking a close look at the condition you have defined and mentally think though how it will act when it receives some valid example input like the discount code "A$" for example.

One hint I'll give is that the change required to fix your code is relatively minor. If you still can't find the issue then I can post a more detailed explanation for you, but I'd suggest trying to fix it on your own first.

Thank you for our advise andren . I check if statement and the "Or" was wrong i change it to and and the code runs great ty.