Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialSarah Parker
2,831 Pointstask 1 is no longer passing... code appears to be correct though...
I added all the details for task 2 and now it says task 1 is failing, but I still meet all of the criteria for task 1
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
private String normalizeDiscountCode (String discountCode){
for (char letter : discountCode.toCharArray()) {
if (letter != '$' || ! Character.isLetter(letter)) {
throw new IllegalArgumentException("Invalid Discount code.");
}
}
return discountCode.toUpperCase();
}
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
try {
this.discountCode = normalizeDiscountCode(discountCode);
} catch (IllegalArgumentException iae){
System.out.println(iae.getMessage());
}
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
1 Answer
Christian Thieme
9,448 PointsHi Sarah,
There are two problems with this code. The first is that we want to make the discount code uppercase before it it run through the for loop. It should look something like this:
private String normalizeDiscountCode (String discountCode){ discountCode = discountCode.toUpperCase(); for (char letter : discountCode.toCharArray()) { if (letter != '$' && ! Character.isLetter(letter)) { throw new IllegalArgumentException("Invalid discount code"); } }
The second is that the applyDiscountCode should look like this:
public void applyDiscountCode(String discountCode) { this.discountCode = normalizeDiscountCode(discountCode); }
Hope this helps!
Christian Thieme
9,448 PointsChristian Thieme
9,448 Pointssorry... i forgot to add the return statement on the last one... this should fix that:
private String normalizeDiscountCode (String discountCode){ discountCode = discountCode.toUpperCase(); for (char letter : discountCode.toCharArray()) { if (letter != '$' && ! Character.isLetter(letter)) { throw new IllegalArgumentException("Invalid discount code"); } } return discountCode;}