Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Still get error on this challenge?!

Inside the major() setter method, set the student's major to a backing property "major". If the student's level is Junior or Senior, the value of the backing property should be equal to the parameter passed to the setter method. If the student is only a Freshman or Sophomore, set the "major" backing property equal to 'None'.

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

  set major(major){
    if (this.credits === 'Junior'||'Senior') {
        this._major = major;
    } else if (this.credits === 'Freshman'|| 'Sophomore'){
            this._major = None;
    }
  }

}
var student = new Student(3.9, 60);

2 Answers

Jennifer Nordell
seal-mask
STAFF
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher

Hi there, arshia mohammadi ! You're doing terrific, but there is a slight problem with your comparison. You are comparing this.credits to the strings "Senior", "Junior", "Sophomore", and "Freshman". But credits is a number. The number of credits determine the level of the student which is why you made get level() function which returns a string. You are meant to compare this.level to those strings instead of this.credits.

Hope this helps! :sparkles:

Sorry but it didn't work

Jennifer Nordell
seal-mask
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher

arshia mohammadi that was the large part of the problem with your conditionals. The second part of the problem is that you are not saying after the || what should be compared. For example, if I wanted a condition to check if variable num is equal to 10 or equal to 50, I would write it like this:

if(num == 10 || num == 50) {
   // Do something here
}

This will not work as expected:

if(num == 10 || 50) {
      // Do something here
}

If this still isn't helpful, you will need to post your code as it is now so that we can take a look :sparkles:

works thank you