Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

jason limmm
jason limmm
8,009 Points
Posted by jason limmm
jason limmm
8,009 Points

something wrong with my code?

it said that there is an unexpected "{" somewhere but i can't find where it is

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
  set major(major){
  if(level==="Junior" || level==="Senior"){
  this._major=major;
  }else(level==="Freshman" || level==="Sophmore"){
  this._major=none;
  }
 }
}
var student = new Student(3.9, 60);

1 Answer

Rohald van Merode
seal-mask
STAFF
.a{fill-rule:evenodd;}techdegree
Rohald van Merode
Treehouse Staff
Rohald van Merode
.a{fill-rule:evenodd;}techdegree
Rohald van Merode
Treehouse Staff

Hey jason limmm 👋

You'll want to have a look at your else block in the major setter. You'll either want to adjust your else to not have a condition or adjust else to be else if

else {
    this._major=none;
}

else if (level==="Freshman" || level==="Sophmore"){
    this._major=none;
}

Hope this helps! 🙂