Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Letter Game App Letter Game Introduction

Laknath Gunathilake
Laknath Gunathilake
1,860 Points

small part of the game is not working-when I win the game it does't print you win! The word was {}

when I win the game "it does't print "you win! The word was {}

<p>
import random
#make a list of words

words=[  'apple',
        'banana',
        'orange',
        'coconut',
        'strawberry',
        'lime',
        'grapefruit',
        'lemon',
        'kumquat',
        'blueberry',
        'melon',
]

while True:
    start=input("press enter/return to start, or enter Q to quit")
    if start.lower()=="q":
        break
    #draw guessed letters, spaces and strikes
    secret_word=random.choice(words)
    bad_guesses=[]
    good_guesses=[]

    while len(bad_guesses)<7 and len(good_guesses) !=len(list(secret_word)):
    #draw spaces
        for letter in secret_word:
            if letter in good_guesses:
                print(letter,end='')
            else:
                print('_',end='')

        print('')
        print ('Strikes:{}/7'.format(len(bad_guesses)))
        print('')

        #take a guess
        guess=input("guess the letter:").lower()

        if len (guess) !=1:
            print("you can only guess a single letter!")
            continue 
        elif guess in bad_guesses or guess in good_guesses:
            print ("you've already guess that letter!")
            continue 
        elif not guess.isalpha():
            print("you can only guess letters!")
            continue 

        if guess in secret_word:
            good_guesses.append(guess)
            if len(good_guesses)==len(list(secret_word)):
                print("you win! The word was {}".format(secret_word))
                break
        else:
            bad_guesses.append(guess)
    else:
        print("You didn't geuess it my secret number was {}".format(secret_word))

    #print out win/lose
</p>

2 Answers

Steven Parker
Steven Parker
231,236 Points

Testing the number of guesses (as len(good_guesses)) against the length of the word will not detect a win, unless the word has no repeated letters. For example, if the word is "apple", you will win in 4 guesses but the word has 5 letters.

:point_right: You need a different way to detect a win. Perhaps test each letter in the word to see if it has been guessed?

Also, you don't need to convert a string to a list to get it's length, instead of len(list(secret_word)) you can just use len(secret_word).

Tessa Sullivan
Tessa Sullivan
1,517 Points

Use the 'set' command to determine the list of unique letters in the word.

if len(good_guesses) == len(set(secret_word)):