Receive error message, seems indentation issue

Question

So this is what I have used:
def loopy(items):
    # Code goes here
       for item in items:
            print(item)
            if item == 'STOP':
                    break
I am quite sure it is an indentation issue but even if I indent the if item loop a bit further I still receive the Bummer error message
```breaks.py
def loopy(items):
    # Code goes here
       for item in items:
            print(item)
            if item == 'STOP':
                    break
```

Greg Kaleka · Accepted Answer

Hi Christian,
You've got two issues with your code. 1. is indentation, which you correctly identified. Note that your indentation is wrong in just the right way - it would still pass the challenge because you've just indented one block of code a bit too much. That said, we should still fix it. It should look like this:
python
def loopy(items):
    # Code goes here
    for item in items:  # no need to indent this further. Still just inside loopy block
        print(item)
        if item == 'STOP':
            break

The second issue is the order of your code. It's not 100% clear from the challenge prompt, but my interpretation - and the code that passes the challenge - is that if the item is "STOP" you should not print that item, but instead break out of the loop immediately. To do this we just need to flip the order of your if..STOP..break and the print statement:
python
def loopy(items):
    # Code goes here
    for item in items:
        if item == 'STOP':
            break
        print(item)

Hopefully that clears things up!
Cheers :beers:
-Greg

Thomas McDonnell · Answer

Hi Christian Geib,
You just have some code a little jumbled up. lets word it out!
for item in items:
........if item == "STOP":
.................break
.........print(item)
I always find playing with my code in the python shell helps needle out some of these kinds of issues.
Hope this helps:)

Welcome to the Treehouse Community

Looking to learn something new?

Christian Geib

Christian Geib

Receive error message, seems indentation issue

2 Answers

Greg Kaleka

Greg Kaleka

Christian Geib

Christian Geib

Thomas McDonnell

Thomas McDonnell

Christian Geib

Christian Geib