Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Shopping List App Refactor

Posted by ronakeogh
ronakeogh
30 Points

python basics, shopping list app, refactor. What am i doing wrong?

n

shopping_list.py 
def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list

def main():
    show_help()
    shopping_list = []
    while True:
        new_item = input("> ")
    if new_item == 'DONE':
        break
    elif new_item == 'HELP':
        show_help()
        continue
    elif new_item == 'SHOW':
        show_list(shopping_list)
        continue
    add_to_list(shopping_list, new_item)
    show_list(shopping_list)
Florian Benkö
Florian Benkö
2,766 Points
Florian Benkö
Florian Benkö
2,766 Points

i am only guessing: at the point you start your while loop. all those ifs you need to itend if you want them to be a part of the loop (you want because you did use break and continue -> can be only used in loops). also the call of the function add_to_list() should be part of the loop ;) maybe you get a bit closer now ;)

ronakeogh
ronakeogh
30 Points

thanks very much that solves my problem. :)

1 Answer

Kristian Gausel
Kristian Gausel
14,661 Points
Kristian Gausel
Kristian Gausel
14,661 Points

Your indentation is slightly off:

def main():   
    show_help()

    # make a list to hold onto our items
    shopping_list = []

    while True:
        # ask for new items
        new_item = input("> ")

        # be able to quit the app
        if new_item == 'DONE':
            break
        elif new_item == 'HELP':
            show_help()
            continue
        elif new_item == 'SHOW':
            show_list(shopping_list)
            continue
        add_to_list(shopping_list, new_item)

    show_list(shopping_list)
ronakeogh
ronakeogh
30 Points

thanks very much, hugely appreciated.