Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects (Retired) Delivering the MVP Validation

Kshatriiya .
Kshatriiya .
1,464 Points
Posted by Kshatriiya .
Kshatriiya .
1,464 Points

Please critique my code

I know the code can be made shorter if I just paste the method in the if field instead of declaring chars but I just wanted to keep it tidy.

I'm wondering if there is a better or just alternative way of achieving the same result? Just so that I could broaden my knowledge.

Thanks in advance :)

public class TeacherAssistant {

  public static String validatedFieldName(String fieldName) {
    char firstChar = 'm';
    char secondChar = fieldName.charAt(1);
    boolean itIsUpperCase = Character.isUpperCase(secondChar);
    if (!(fieldName.charAt(0) == firstChar) || !(itIsUpperCase)) {
      throw new IllegalArgumentException("Member field should start with an 'm' and second letter in upper case");
    }
    // These things should be verified:
    // 1.  Member fields must start with an 'm'
    // 2.  The second letter in the field name must be uppercased to ensure camel-casing
    // NOTE:  To check if something is not equal use the != symbol. eg: 3 != 4
    return fieldName;
  }

}

1 Answer

Grigorij Schleifer
Grigorij Schleifer
10,365 Points
Grigorij Schleifer
Grigorij Schleifer
10,365 Points

Hi Kshatriiya,

you can create and validate your variables inside of the parenthesis of the if statement.

public class TeacherAssistant {

  public static String validatedFieldName(String fieldName) {
    if (fieldName.charAt(0) != 'm' || ! Character.isUpperCase(fieldName.charAt(1)) || ! Character.isLetter(fieldName.charAt(1))) {
// first condition proofs if the irst char is 'm'
// second condition proofs if the second char is uppercased
// third condition proofs if the char is a letter to avoid this error (Expected "m_first_name" to fail but it passed)
      throw new IllegalArgumentException("Not a valid field name...");
    }
    return fieldName;
  }
}

Grigorij