Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialAlbert Kirchmeyr
11,410 PointsPart 1 no longer passing
After passing task 1 I check for letters and the $ sign....after my check I get part 1 is no longer passing....
WHY?
public class Order { private String itemName; private int priceInCents; private String discountCode;
public Order(String itemName, int priceInCents) { this.itemName = itemName; this.priceInCents = priceInCents; }
public String getItemName() { return itemName; }
public int getPriceInCents() { return priceInCents; }
public String getDiscountCode() { return discountCode; }
public void applyDiscountCode(String discountCode) { try { this.discountCode = normalizeDiscountCode(discountCode); } catch (IllegalArgumentException iae) { System.out.println(iae.getMessage()); } }
private String normalizeDiscountCode(String discountCode) {
discountCode = discountCode.toUpperCase();
for (char check : discountCode.toCharArray()) {
if (! Character.isLetter(check) || check != '$') {
throw new IllegalArgumentException("Invalid discount code");
}
}
return discountCode;
}
}
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
try {
this.discountCode = normalizeDiscountCode(discountCode);
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage());
}
}
private String normalizeDiscountCode(String discountCode) {
discountCode = discountCode.toUpperCase();
for (char check : discountCode.toCharArray()) {
if (! Character.isLetter(check) || check != '$') {
throw new IllegalArgumentException("Invalid discount code");
}
}
return discountCode;
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
1 Answer
Yanuar Prakoso
15,196 PointsHi Albert The problem is in your if statement. This is your if statement:
if (! Character.isLetter(check) || check != '$') //this is wrong
It should be:
if ( !( Character.isLetter(check) || check == '$'))
The request is to verify whether the Discount code contains only letters or "$" character. If Not then throw exception. Thus we may say IF there is any character is NOT(letters OR "$") THEN Throw something. Thus if we write it in logical expression it will be like: if (NOT(Character.isLetter(check) OR check =="$"))
in other word: if (!(Character.isLetter(check) || check == "$"))
If you still wanted to includes the negation operator (which is the ! character) attached to each statement you may do so but please the OR operator (the ||) into AND operator ('&&'). Like this:
if (!Character.isLetter(check) && check != '$')
for the reason of this please search through Google about logical expressions if you are still curious.
I hope this can help you pass the challenge.
Albert Kirchmeyr
11,410 PointsAlbert Kirchmeyr
11,410 PointsThank you! It's so easy to oversee this things!
Thank you for your great explanation!