Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

gaetan mertens
gaetan mertens
1,002 Points
Posted by gaetan mertens
gaetan mertens
1,002 Points

Oops! It looks like Task 1 is no longer passing.

But when I go back to task 1, and dont change anything it passes.

Order.java 
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  private boolean isAlpha(String text) {
    char[] chars = text.toCharArray();
    char a = '$';
    for (char c : chars) {
        if(! Character.isLetter(c) || ! (c==a) ) {
            return false;
        }
    }
    return true;
}

  private String normalizeDiscountCode(String discountCode) {
    if (! isAlpha(discountCode)) {
     throw new IllegalArgumentException("Invalid discount code");
    }
    discountCode = discountCode.toUpperCase();
    return discountCode;
  }

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    discountCode = normalizeDiscountCode(discountCode);
    this.discountCode = discountCode;
  }
}
Example.java 
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}
Binyamin Friedman
Binyamin Friedman
14,615 Points
Binyamin Friedman
Binyamin Friedman
14,615 Points

First thing I notice is that you did this

discountCode = normalizeDiscountCode(discountCode);
this.discountCode = discountCode;

instead of this

this.discountCode = normalizeDiscountCode(discountCode);

I also don't think that you are correctly checking for a valid discount code. I won't give you the exact code, but try to loop over every character and check if the character is not a letter and if the character is not the letter '$' when both of these are true, then throw the exception.