Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by margarethepadysz
margarethepadysz
Courses Plus Student 3,792 Points

Not sure why wrong value is returned

Hi, I am not sure why the wrong value is returned since I thought that I wrote the correct if-Statement. Thanks for helping me out!

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

  set major(major) {
    this._major = major;
    if (this.level === 'Senior' || 'Junior') {
        return this.level;
        } else {
        return 'None';
        }
  }
}

var student = new Student(3.9, 60);

2 Answers

rnw98613
rnw98613
348 Points
rnw98613
rnw98613
348 Points

Hi, check this out;

class Student {

    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits >= 90 ) {
            return 'Senior';
        }
        else if (this.credits >= 60) {
            return 'Junior';
        }
        else if (this.credits >= 30) {
            return 'Sophomore';
        }
        else {
            return 'Freshman';
        }
    }

  set major(major) {
    this._major = major;

    if (this.level === 'Senior' || this.level === 'Junior') {
        return this.level;
    }
    else {
        return 'None';
    }
  }
}

var student = new Student(3.9, 60);
margarethepadysz
margarethepadysz
Courses Plus Student 3,792 Points

This doesn't work either - unfortunately...

margarethepadysz
PLUS
margarethepadysz
Courses Plus Student 3,792 Points
margarethepadysz
margarethepadysz
Courses Plus Student 3,792 Points

Ok, now I got it on my own:

set major (major) {
this._major = major;
if(this.level === 'Senior' || this.level === 'Junior') {
return this._major;
} else {
this._major = 'None';
return this._major;
}
}

But thanks for the if-condition!