Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialCarlo Antonio Bilbao
24,113 PointsNot sure why I'm getting this error...
Not sure what error is in line 9...
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
private String normalizeDiscountCode(String discountCode) {
for (char letter : discountCode.toCharArray()) {
if (! Character.isLetter(letter) || !discountCode.contains("$")) {
throw new IllegalArgumentException("Invalid discount code");
}
}
this.discountCode = discountCode.toUpperCase();
return this.discountCode;
}
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
1 Answer
Alex Bratkovskij
5,329 PointsHeya Carlo,
if (! Character.isLetter(letter) || !discountCode.contains("$")) {
For the reasons that I do not know, OR doesn't like double denial, so I would suggest you to wrap them under one bracket and then your code will execute.
like so:
if (! (Character.isLetter(letter) || discountCode.contains("$"))){
Bare in mind that although this code will execute, you will not get task complete cuz discountCode.conains("$") does let through this : $@ving$ . Try using a letter and checking if it's equal to $, since you already flipping through them ;)
Good Luck!
-Alex
ceriannejackson
23,759 Pointsceriannejackson
23,759 PointsWhat error message are you getting?