Not sure what's wrong with my code

Question

I created the method to convert the string to upper case but I'm still getting an error saying that it's still lower case.

Order.java

public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
     return discountCode;
  }
private String normalizeDiscountCode(String discountCode){
    this.discountCode=discountCode.toUpperCase();
    return discountCode;
  }
  public void applyDiscountCode(String discountCode) {
     this.discountCode = normalizeDiscountCode(discountCode);

  }

}

Example.java

public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

Answer 1 · 2018-11-25T18:51:51Z

November 25, 2018 6:51pm

So, it looks like you are still returning the lowercase version of the discount code because you are changing the this.discountCode variable and returning the variable that was passed in which is still all lowercase. Try changing your code to this:

  private String normalizeDiscountCode(String discountCode) {
    return discountCode.toUpperCase();
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }

Welcome to the Treehouse Community

Looking to learn something new?

Leo Marco Corpuz

Leo Marco Corpuz

Not sure what's wrong with my code

1 Answer

James Meyer

James Meyer