Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Theodore Lewis
Theodore Lewis
2,058 Points

Not sure what my problem is with this Code.

I've tried everything that I could think of. Can someone please explain to me my error? After I try and complete task 2, it tells me that task 1 can no longer pass.

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }  
  private String normalizeDiscountCode(String discountCode){
    if(! discountCode.matches("[a-zA-Z]+")|| ! discountCode.matches("[$]*")){
    throw new IllegalArgumentException("Invalid discount code.");
    }
    this.discountCode = discountCode;
        return discountCode.toUpperCase();
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Joshua O'Brian
Joshua O'Brian
20,747 Points

So issue one you are setting have some duplicates

this is not needed:

private String normalizeDiscountCode(String discountCode){
// if you add a $ to the first regex expression and  replace the || (or) with a && (and) statement it will pass
// you might not even need the second statement 
    if(! discountCode.matches("[$a-zA-Z]+")|| ! discountCode.matches("[$]*")){
    throw new IllegalArgumentException("Invalid discount code.");
    }
// this can be removed because you are setting it in the apply method by calling this method and returning it
    this.discountCode = discountCode;
        return discountCode.toUpperCase();
  }