Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialGorka Berzal
18,363 PointsnormalizeDiscountCode
When I finish the task two of this exercise the system gives a message that the task one is no longer valid. I am not sure what I am doing wrong here. A hand would be very much appreciated. Thanks.
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
try{
this.discountCode = normalizeDiscountCode( discountCode);
}catch(IllegalArgumentException iae){
System.out.println(iae.getMessage()) ;
}
}
private String normalizeDiscountCode( String discountCode) {
for (char letter : discountCode.toCharArray()) {
if (!Character.isLetter(letter) || letter != '$') {
throw new IllegalArgumentException("Invalid discount code.");
}
}
return discountCode.toUpperCase();
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
1 Answer
Rares Conea
Courses Plus Student 15,000 PointsHi,
The if statement is wrong, if you call the method with a String that containts only letters the !Character.isLetter() will return false but the != "$" will return true so the IllegalArgumentException will be thrown. Put && instead of ||