Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialJethro Ocean
2,458 PointsnormalizedDiscount Help!
I don't know what is wrong :( please help.
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
private String normalizeDiscountCode(String discountCode) {
for (char let : discountCode.toCharArray() ) {
if ( (!Character.isLetter(let)) || (discountCode.indexOf('$') == -1) ) {
throw new IllegalArgumentException("Invalid discount code");
}
}
String result = discountCode.toUpperCase();
return result;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
1 Answer
Jethro Ocean
2,458 PointsThanks for your answer! I actually have completed this challenge already. I comparing the '$' per letter in the conditional statement rather than the whole string.
Craig Dennis
Treehouse TeacherCraig Dennis
Treehouse TeacherHi Jethro Lee Ocean !
What error message are you getting?
One thing I see is that you could check each of those letters going through to see if it is a
'$'
instead of checking to see if it is in the entire string. One reason is because!!#@S$
would pass part the second side of the OR.That make sense?