Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialRikki MCguire
2,232 Pointsnormalize $ sign
I have tried this code in workspace. When i run anything with the $ at the end returns uppercase all ok eg ad$ returns AD$. if i did a1$ it throws exception for 1.
If i send int $ in the middle eg e$1 it doesnt throw and exception but returns E. and if the $ is at the front $eg i get: ArrayIndexOutOfBounds..
WTH is going on been trying for 4 days now....
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
private String normalizeDiscountCode(String discountCode){
for (char letter : discountCode.toUpperCase().toCharArray()){
if (!Character.isLetter(letter) && letter != '$'){
throw new IllegalArgumentException("Invalid discount code");
}
}
return discountCode.toUpperCase();
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
try{
this.discountCode = normalizeDiscountCode(discountCode);
} catch (IllegalArgumentException iae){
System.out.printf(iae.getMessage());
}
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
1 Answer
Rikki MCguire
2,232 PointsI added toUpperCase() at the end as the code challenge was saying it wasnt returning so i tried that. and as for IllegalArgumentException you are wrong that is the incorrect format. iae is specified in the try catch statement not in the throw statement.
Here it is on the oracle website;
IllegalArgumentException() Constructs an IllegalArgumentException with no detail message. IllegalArgumentException(String s) Constructs an IllegalArgumentException with the specified detail message. IllegalArgumentException(String message, Throwable cause) Constructs a new exception with the specified detail message and cause.
Amrit Pandey
17,595 PointsAmrit Pandey
17,595 PointsI cannot understand fully what you want to achieve but lets examine you code.
Few pitfalls that you created,
.toUpperCase
twice in you code, since we want uppercase discount code already why not do it first.I am just correcting your function, It have nothing to do with the code challenge, please watch video for that.