Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialMolly Christie
4,564 PointsNavigation does not adjust for desktop site
I cannot for the life of me figure out what I've done wrong. My CSS is valid but for some reason when I make the changes to the navigation for the desktop site the nav still sits under the header.
My html is as follows
<html>
<head>
<meta charset="utf-8">
<link rel="stylesheet" href="css/normalize.css">
<link href='http://fonts.googleapis.com/css?family=Changa+One:400,400italic|Open+Sans:400italic,400' rel='stylesheet' type='text/css'>
<link rel="stylesheet" href="css/main.css">
<link rel="stylesheet" href="css/responsive
.css">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Molly Christie | Wizard</title>
</head>
<body>
<header>
<a href="index.html" id="logo">
<h1>Molly Christie</h1>
<h2>Wizard</h2>
</a>
</header>
<nav>
<ul>
<li><a href="index.html" class="selected">Portfolio</a></li>
<li><a href="about.html">About</a></li>
<li><a href="contact.html">Contact</a></li>
</ul>
</nav>
<div id="wrapper">
<section>
<ul id="gallery">
<li>
<a href="img/malawi29.jpg">
<img src="img/malawi29.jpg" alt="">
<p>Walking home through the botanical garden.</p>
</a>
</li>
<li>
<a href="img/malawi31.jpg">
<img src="img/malawi31.jpg" alt="">
<p>Rainforest.</p>
</a>
</li>
<li>
<a href="img/malawi34.jpg">
<img src="img/malawi34.jpg" alt="">
<p>View of Zomba sligtly to the south from the Top Road.</p>
</a>
</li>
<li>
<a href="img/malawi35.jpg">
<img src="img/malawi35.jpg" alt="">
<p>View of Zomba sligtly to the north from the Top Road.</p>
</a>
</li>
<li>
<a href="img/malawi36.jpg">
<img src="img/malawi36.jpg" alt="">
<p>Time to head home.</p>
</a>
</li>
</ul>
</section>
<footer>
<a href="http://twitter.com/mollyec"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
<a href="http://facebook.com/mollychristie"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
<p>© 2014 Molly Christie.</p>
</footer>
</div>
</body>
</html>
/************
GENERAL
*************/
body {
font-family: 'Open Sans', sans-serif;
}
a {
text-decoration:none;
}
#wrapper{
max-width: 940px;
margin: 0 auto;
padding:0 5%;
clear: both;
}
img {
max-width:100%;
}
h3 {
margin: 0 0 1em 0;
}
/************
HEADING
*************/
header {
float: left;
margin: 0;
padding: 0px 0 5px 0;
width: 100%;
}
#logo {
text-align: center;
margin: 0;
}
h1 {
font-family: 'Changa One', sans-serif;
margin: 15px 0;
font-size: 1.75em;
font-weight: normal;
line-height: 0.8em;
}
h2 {
font-size: 0.75em;
margin: -5px 0 0;
font-weight: normal;
}
/***********
Navigation
*************/
nav {
text-align: center;
padding: 10px 0;
margin: 20px 0 0;
}
nav ul {
list-style: none;
margin: 0 10px;
padding: 0;
}
nav li {
display: inline-block;
}
nav a {
font-weight: 800;
padding: 15px 10px;
}
/**************
FOOTER
***************/
footer {
font-size:0.75em;
text-align:center;
clear: both;
padding-top: 50px;
color: #999;
}
.social-icon {
width: 20px;
height: 20px;
margin: 0 5px;
}
/************
Page: Portfolio
*************/
#gallery{
margin:0;
padding:0;
list-style: none;
}
#gallery li {
float: left;
width: 45%;
margin: 2.5%;
background-color: #f5f5f5;
color: #bdc3c7;
}
#gallery li a p{
margin: 0;
padding: 5%;
font-size: 0.75em;
color: #bdc3c7;
text-align:center;
}
/************
PAGE: ABOUT
*************/
.profile-photo {
display: block;
max-width: 150px;
margin-left: auto;
margin-right: auto;
border-radius: 100%;
margin-top: 10%
}
/************
PAGE: CONTACT
*************/
.contact-info {
list-style: none;
text-decoration: none;
padding: 0;
margin: 0;
font-size: 0.9em;
}
.contact-info a {
display:block;
min-height: 20px;
background-repeat: no-repeat;
background-size: 20px 20px;
padding: 0 0 0 30px;
margin: 0 0 10px;
}
.contact-info li.phone a {
background-image: url('../img/phone.png');
}
.contact-info li.mail a {
background-image: url('../img/mail.png');
}
.contact-info li.facebook a {
background-image: url('../img/facebook.png');
}
/************
COLORS
*************/
/* site body */
body {
background-color: #fff;
color: #999;
}
/* green header */
header {
background: #6ab47b;
border-color: #599a68;
}
/* nav background on mobile */
nav {
background: #599a68;
}
/* logo text */
h1, h2 {
color: #fff;
}
/* links */
a {
color: #6ab47b;
}
/* nav link */
nav a, nav a:visited {
color: #fff;
}
/* selected nav link */
nav a.selected, nav a:hover {
color: #32673f;
}
@media screen and (min-width: 480px) {
/**********************************
TWO COLUMN LAYOUT
***********************************/
#primary {
width: 50%;
float: left;
}
#secondary {
width: 40%;
float: right;
}
/**********************************
PAGE: PORTFOLIO
***********************************/
#gallery li {
width: 28.3333%;
}
#gallery li:nth-child(4n) {
clear: left;
}
/**********************************
PAGE: ABOUT
***********************************/
.profile-photo {
float: left;
margin: 0 5% 80px 0;
}
}
@media screen and (min-width: 660px) {
/**********************************
HEADER
***********************************/
#logo {
float: left;
margin-left: 5%;
text-align: left;
width: 45%;
}
nav {
background: none;
float: right;
font-size: 1.125em;
margin-right: 5%;
text-align: right;
width: 45%;
}
h1 {
font-size: 2.5em;
}
h2 {
font-size: 0.825em;
margin-bottom: 20px;
}
header {
border-bottom: 5px solid #599a68;
margin-bottom: 60px;
}
I've put everything into codepen here http://codepen.io/mmmolly/pen/iImFn/ and I'd be very grateful if anyone had any insights.
I'm really losing my marbles over here.
Thanks!
2 Answers
chriscameron
15,397 PointsYou don't have your nav inside your header.
Molly Christie
4,564 PointsThank you! Phew!