Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Basics Perfecting the Prototype Looping until the value passes

Perdana Anwar
Perdana Anwar
889 Points
Posted by Perdana Anwar
Perdana Anwar
889 Points

My code works in the workspaces but not in the challenge.

Here is my code

String who; do{ // Person A asks: console.printf("Knock Knock.\n");

// Person B asks and Person A's response is stored in the String who: who = console.readLine("Who's there? ");

// Person B responds: console.printf("%s who?\n", who); if(who.equalsIgnoreCase("orange")){ console.printf("Orange you glad I didn't say banana?"); System.exit(0); } }while(who.equalsIgnoreCase("banana"));

KnockKnock.java 
/*  So the age old knock knock joke goes like this:

    Person A:  Knock Knock.
    Person B:  Who's there?
    Person A:  Banana
    Person B:  Banana who?
    ...as long as Person A has answered Banana the above repeats endlessly
    ...assuming the person answers Orange we'd see
    Person B:  Orange who?
    ...and then the punchline.
    Person A:  Orange you glad I didn't say Banana again?
    (It's a really bad joke that makes it sound like "Aren't you glad I didn't say Banana again?")

    Let's just assume the only two words passed in from the console from Person B are either banana or orange.
*/

// ====BEGIN PROMPTING CODE====

 String who;
do{
// Person A asks:
console.printf("Knock Knock.\n");

// Person B asks and Person A's response is stored in the String who:
who = console.readLine("Who's there?  ");

// Person B responds:
console.printf("%s who?\n", who);
  if(who.equalsIgnoreCase("orange")){
   console.printf("Orange you glad I didn't say banana?");
    System.exit(0);
  }
}while(who.equalsIgnoreCase("banana"));

// ==== END PROMPTING CODE ====

2 Answers

Craig Dennis
STAFF
Craig Dennis
Treehouse Teacher
Craig Dennis
Craig Dennis
Treehouse Teacher

Super close!

You shouldn't need the if in the while loop,who is checked each iteration through the loop. Try just putting the punchline outside the loop, after all if it is out of the loop, they are no longer answering with banana.

Craig Dennis
Craig Dennis
Treehouse Teacher
Craig Dennis
Craig Dennis
Treehouse Teacher

(The System.exit(0) is fowling up the test runner)

Perdana Anwar
Perdana Anwar
889 Points
Perdana Anwar
Perdana Anwar
889 Points

Thank you for the quick response Craig. My final code turned out to be

 String who;
do{
// Person A asks:
console.printf("Knock Knock.\n");

// Person B asks and Person A's response is stored in the String who:
who = console.readLine("Who's there?  ");

// Person B responds:
console.printf("%s who?\n", who);
}while(who.equalsIgnoreCase("banana"));
  if(who.equalsIgnoreCase("orange")){
   console.printf("Orange you glad I didn't say banana?");
  }

I also had to get rid of the System.exit code to make it function properly.