Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Shopping List App Refactor

My answer is getting a "Bummer! Didn't get the help message" even though I followed the question. What did I do wrong?

Challenge Task 1 of 1

This challenge is a little different. You shouldn't have to write very much code. You probably recognize this code. It's pretty much our shopping_list_2.py from before. I want you to help me with a little refactor, though. Refactoring is when we change code to make it better, often by creating new functions. Create a new function named main that doesn't take any arguments. Move everything from line 22 (show_help()) and below into your new function. You shouldn't have any code that isn't inside of a function.

My answer:

def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list

def main():    

    show_help()

    # make a list to hold onto our items
    shopping_list = []

    while True:
        # ask for new items
        new_item = input("> ")

        # be able to quit the app
        if new_item == 'DONE':
            break
        elif new_item == 'HELP':
            show_help()
            continue
        elif new_item == 'SHOW':
            show_list(shopping_list)
            continue
        add_to_list(shopping_list, new_item)

    show_list(shopping_list)

[MOD: fixed formatting -cf]

3 Answers

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 68,441 Points

The grader is very picky. Try removing the whitespace from the end of the line:

def main():

Yes, it worked. I tried to remove the whitespace as you mentioned. Thanks!

Thank you! I was so confused, I couldn't figure out what was going on!

willyraider
willyraider
6,550 Points

I was too lazy to indent all the lines below show_help(). It resulted in a bummer although the code was correct. Bad user experience :D

Is there a shortcut for this web terminal in order to indent all marked lines?

Chris Freeman
Chris Freeman
Treehouse Moderator 68,441 Points

In workspaces, you can indent a highlighted block of code (or current line) using Ctrl-[ and Ctrl-]

just above show_help before adding the " def main():" function there is additional whitespace remove it. and highlight everything below starting from show _help () and indent

Silly - refactoring is important but this task seems silly and the editor experience in this case needs a better feedback mechanism. Let's learn python not frustrate people!