Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialJonathan Hartmayer
5,626 PointsLetters validation: better solution?
Did anyone get a cleaner or simpler solution than the following:
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
private String normalizeDiscountCode(String discountCode) {
for (int i = 0; i < discountCode.length(); i++) {
if (!Character.isLetter(discountCode.charAt(i))) {
if (discountCode.charAt(i) != '$') {
throw new IllegalArgumentException("Invalid discount code");
}
}
} return discountCode.toUpperCase();
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
2 Answers
Rares Conea
Courses Plus Student 15,000 Pointsprivate String normalizeDiscountCode(String discountCode){ for(int i = 0 ; i < discountCode.length(); i++){ if(!(Character.isLetter(discountCode.charAt(i)) || discountCode.charAt(i) == '$')){ throw new IllegalArgumentException("Invalid discount code"); } } return discountCode.toUpperCase(); }
Rares Conea
Courses Plus Student 15,000 PointsYou can use lambdas: https://i.imgur.com/mU2FQJD.png
To make this work make sure you add these lines: import java.util.List; import java.util.stream.Collectors;
Jonathan Hartmayer
5,626 PointsJonathan Hartmayer
5,626 PointsThanks for the response. Yes, that works too. I guess my question was if there was a solution that didn't require a for loop?