Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Number Game App String length

X TAO-COLLINS
X TAO-COLLINS
4,922 Points
Posted by X TAO-COLLINS
X TAO-COLLINS
4,922 Points

just_right(string)

I have tried my scripts in Python 3.6.1 shell, it runs through perfectly and gives me the correct answer. Can anyone help me what is wrong with my scripts?

def just_right(str): str=[] if len(str)<5: return("Your string is too short") elif len(str)>5: return("Your string is too long") else: return(True)

just_right("big") 'Your string is too short'

strlen.py 
def just_right(str):
    str=[]
    if len(str)< 5:
        return("Your string is too short")
    elif len(str)> 5:
        return("Your string is too long")
    else:
        return(True)

1 Answer

andren
andren
28,558 Points
andren
andren
28,558 Points

The issue is the first line of your function:

str=[]

You set str, which is the parameter passed in to the function, to an empty array. Meaning that no matter what is passed in to the function, it will always just be overwritten with an empty array.

If you remove that line then your function will work.