Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

mihai tudose
mihai tudose
3,029 Points

java object

I dont know how to verify if my character is $ so that i dont throw an exception in that case. can anyone help me?

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  private String normalizeDiscountCode(String discountCode){
    discountCode = discountCode.toUpperCase();
    for(char letter: discountCode.toCharArray()){
      if(Character.isLetter(letter) == false ) {
        throw new IllegalArgumentException("Invalid discount code");
      }
    }
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);

  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

2 Answers

Yanuar Prakoso
Yanuar Prakoso
15,196 Points

Hi there...

You need to use or and negation operator in your if statement. This is how I will use to pass the challege:

 private String normalizeDiscountCode(String discountCode){
    discountCode = discountCode.toUpperCase();
    for(char letter: discountCode.toCharArray()){
      //if(Character.isLetter(letter) == false ) {<--this is incomplete. It should be coded as: (look below)
         if(!(Character.isLetter(letter) || letter == '$')) {//<-- this is comply with statement NOT(a letter OR '$')
        throw new IllegalArgumentException("Invalid discount code");
      }
    }
    return discountCode;
  }

I hope this will help

mihai tudose
mihai tudose
3,029 Points

Thanks i understand now