It looks like task 1 is not passing

Question

Task 1 is to return discountCode in upper case.  Task 2 is to throw illegal argument exception if it's not a letter or $.  The following code says task 1 is not passing anymore, and I don't know why.  
  private String normalizeDiscountCode(String discountCode2){
    this.discountCode = discountCode2.toUpperCase();
    for (char letter : discountCode2.toCharArray()){
      if (! Character.isLetter(letter)  || letter != '$'){
       throw new IllegalArgumentException("Invalid discount code");
      }
    }
   return this.discountCode;
  }
```Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;
  private String normalizeDiscountCode(String discountCode2){
    this.discountCode = discountCode2.toUpperCase();
    for (char letter : discountCode2.toCharArray()){
      if (! Character.isLetter(letter)  || letter != '$'){
       throw new IllegalArgumentException("Invalid discount code");
      }
    }
   return this.discountCode;
  }
  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }
  public void applyDiscountCode(String discountCode) {
    this.discountCode = discountCode;
    normalizeDiscountCode(this.discountCode);
  }
}
```

Steve Hunter · Accepted Answer

Hi there, 
There's a few issues in here. 
First, don't set this.discountCode in this method. That gets done in the applyDiscountCode() method already. 
Next, you've set the member variable, i.e. this.discountCode, before doing the validation so incorrect codes are capable of being put into the member variable, rather than the IllegalArgumentException catching these invalid codes. 
In applyDiscountCode() you have called normalizeDiscountCode but not assigned it's returned value back into this.discountCode. You have also passed the member variable into the second method, rather than the parameter. The applyDiscountCode() method receives the code for processing. It sends it to normalizeDiscountCode() for validation, then what's returned into the member variable. Your method hasn't used the parameter at all. So, you need to send the parameter to normalize... and assign the returned value into this.discountCode. That would look like:  
java
  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }

Back to normalizeDiscountCode(); first sort the returned value. That is the parameter the method receives (sent by applyDiscountCode) made uppercase. So, we can handle the receipt and onward transmission of the code with this:
java
private String normalizeDiscountCode(String discountCode){
  return discountCode.toUpperCase();
}

Now we need to figure out the validation. You've pretty much got that spot on already! :+1: However, you used OR, when I think this needs an AND. Tidying up, taking all the above into account, and you get something like this:
```java
  private String normalizeDiscountCode(String discountCode){
   for (char letter : discountCode.toCharArray()){
      if (! Character.isLetter(letter)  && letter != '$'){
       throw new IllegalArgumentException("Invalid discount code");
      }
    } 
   return discountCode.toUpperCase();
  }  
```
I hope that helps. Give me a shout if you need more on this - there's a lot in there! I hope it all works, too! :smile: 
Steve.

Zijun Tong · Answer

Hi Steve, that worked perfectly!!  Thanks for the detailed explanation =)
Zijun

Welcome to the Treehouse Community

Looking to learn something new?

Zijun Tong

Zijun Tong

It looks like task 1 is not passing

2 Answers

Steve Hunter

Steve Hunter

Zijun Tong

Zijun Tong

Steve Hunter

Steve Hunter