it doesnt like line 25.. help plz

Question

Cant figure out how to compare the letters in an array to a single letter one at a time.

ScrabblePlayer.java

public class ScrabblePlayer {
  // A String representing all of the tiles that this player has
  private String tiles;

  public ScrabblePlayer() {
    tiles = "";
  }

  public String getTiles() {
    return tiles;
  }

  public void addTile(char tile) {
    tiles += tile;
  }

  public boolean hasTile(char tile) {
    return tiles.indexOf(tile) != -1;
  }

  public int getCountOfLetter(char letter1) {
        int counter = 0;

    for (char letter : tiles.toCharArray()) {
      if (tiles == letter) {
        counter++;
      }
    }
     return counter;
    }
}

Example.java

// This code is here for example purposes only
public class Example {

  public static void main(String[] args) {
    ScrabblePlayer player1 = new ScrabblePlayer();
    player1.addTile('d');
    player1.addTile('d');
    player1.addTile('p');
    player1.addTile('e');
    player1.addTile('l');
    player1.addTile('u');

    ScrabblePlayer player2 = new ScrabblePlayer();
    player2.addTile('z');
    player2.addTile('z');
    player2.addTile('y');
    player2.addTile('f');
    player2.addTile('u');
    player2.addTile('z');

    int count = 0;
    // This would set count to 1 because player1 has 1 'p' tile in her collection of tiles
    count = player1.getCountOfLetter('p');
    // This would set count to 2 because player1 has 2 'd'' tiles in her collection of tiles
    count = player1.getCountOfLetter('d');
    // This would set 0, because there isn't an 'a' tile in player1's tiles
    count = player1.getCountOfLetter('a');

    // This will return 3 because player2 has 3 'z' tiles in his collection of tiles
    count = player2.getCountOfLetter('z');
    // This will return 1 because player2 has 1 'f' tiles in his collection of tiles
    count = player2.getCountOfLetter('f');
  }
}

Answer 1 · 2018-05-09T02:26:23Z

May 9, 2018 2:26am

Hi Ray

You need to fix your for loop:

public int getCountOfLetter(char letter1) {
        int counter = 0;

    for (char letter : tiles.toCharArray()) {
      if (tiles == letter) {//<--this comparison make no sense
        counter++;
      }
    }
     return counter;
    }

at the part that I put comment on basically what you did was after taking one character from a String called tiles and named it letter, you compare that one character (letter) back to whole characters in a String called tiles.

This is how you should code it:

public int getCountOfLetter(char letter){
    int counter = 0;
    for(char tile : tiles.toCharArray()){
      if(tile == letter){
        counter++;
      }
    }
    return counter;
  }

in this method you will input a character named letter. Then you have a String (which is actually a group of characters) called tiles. You need to count how many characters inside the String tiles that matches the letter character. Thus you user for loop to iterate each character inside tiles. Therefore you need to separate the String into characters array to be able to be iterated using for loop. You pull each character from the tiles and store it into variable name tile. Then you compare tile to letter, if it match then the counter will be incremented, if not the program will just move on to the next character inside the tiles.

I hope this can help a little.

Welcome to the Treehouse Community

Looking to learn something new?

Ray Green

Ray Green

it doesnt like line 25.. help plz

1 Answer

Yanuar Prakoso

Yanuar Prakoso