I'm ridiculously stuck and I can't even explain. I can't do the for loop right or check statement right. Please help.

Question

Can't figure it out. I have been through the video about 3 times.

ScrabblePlayer.java

public class ScrabblePlayer {
  // A String representing all of the tiles that this player has
  private String tiles;
  private int counter;
  public ScrabblePlayer() {
    tiles = "";
  }

  public String getTiles() {
    return tiles;
  }

  public void addTile(char tile) {
    tiles += tile;
  }

  public boolean hasTile(char tile) {
    return tiles.indexOf(tile) != -1;
  }

  public int getCountOfLetter(char letter) {

    for (char tile : tiles.toCharArray()) {
      counter = 0;
      if (hasTile(tile) == hasTile(letter)) {
        counter++;
      }
    }

    return counter;
  }
}

Example.java

// This code is here for example purposes only
public class Example {

  public static void main(String[] args) {
    ScrabblePlayer player1 = new ScrabblePlayer();
    player1.addTile('d');
    player1.addTile('d');
    player1.addTile('p');
    player1.addTile('e');
    player1.addTile('l');
    player1.addTile('u');

    ScrabblePlayer player2 = new ScrabblePlayer();
    player2.addTile('z');
    player2.addTile('z');
    player2.addTile('y');
    player2.addTile('f');
    player2.addTile('u');
    player2.addTile('z');

    int count = 0;
    // This would set count to 1 because player1 has 1 'p' tile in her collection of tiles
    count = player1.getCountOfLetter('p');
    // This would set count to 2 because player1 has 2 'd'' tiles in her collection of tiles
    count = player1.getCountOfLetter('d');
    // This would set 0, because there isn't an 'a' tile in player1's tiles
    count = player1.getCountOfLetter('a');

    // This will return 3 because player2 has 3 'z' tiles in his collection of tiles
    count = player2.getCountOfLetter('z');
    // This will return 1 because player2 has 1 'f' tiles in his collection of tiles
    count = player2.getCountOfLetter('f');
  }
}

Answer 1 · 2017-04-14T18:48:45Z

April 14, 2017 6:48pm

Ah - I forgot to declare "counter".

Also, we shouldn't declare the counter inside the loop. That will reset it every time the loop runs

the code should look like this

public int getCountOfLetter(char letter) {
    int counter = 0;
    for (char tile : tiles.toCharArray()) {
        if (tile == letter) {
            counter++;
        }
    }

    return counter;
}

Answer 2 · 2017-04-14T12:41:33Z

April 14, 2017 12:41pm

You're overthinking this;

Why use hasTile in your if-statement?

This is enough:

public int getCountOfLetter(char letter) {
    for (char tile : tiles.toCharArray()) {
        counter = 0;
        if (tile == letter) {
            counter++;
        }
    }

    return counter;
}

Welcome to the Treehouse Community

Looking to learn something new?

Camille C

Camille C

I'm ridiculously stuck and I can't even explain. I can't do the for loop right or check statement right. Please help.

2 Answers

Thomas Nilsen

Thomas Nilsen

Camille C

Camille C

Thomas Nilsen

Thomas Nilsen

Camille C

Camille C