Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Shopping List App Refactor

I'm not sure I'm understanding the scope of this question. What am I missing?

I've added def main() like requested. There's another line that says "Everything should be in a function." Have I missed that? Isn't everything in a function?

shopping_list.py
def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list

def main()

# make a list to hold onto our items
    shopping_list = []

    while True:
    # ask for new items
        new_item = input("> ")

    # be able to quit the app
        if new_item == 'DONE':
            break
        elif new_item == 'HELP':
            show_help()
            continue
        elif new_item == 'SHOW':
            show_list(shopping_list)
            continue
        add_to_list(shopping_list, new_item)
show_list(shopping_list)

2 Answers

Jennifer Nordell
seal-mask
STAFF
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher

Hi there! I feel like you are understanding this challenge for the most part. However, there are two problems here. The first problem is that there is now a line of code that's missing completely that was there before. It's the line that calls the show_help function. I suspect that instead of writing the main function before it, you accidentally wrote it over it.

The final problem is the very last line. It isn't indented at all which means it's not inside the main function, but rather in the global scope.

Hope this helps! :sparkles:

So, I've gone through it again. I'm still getting the "bummer," but I'm not sure whether the indentation is off or not.

def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list

def main():    
    def show_help():

        # make a list to hold onto our items
        shopping_list = []

        while True:
            # ask for new items
            new_item = input("> ")

            # be able to quit the app
            if new_item == 'DONE':
            break
            elif new_item == 'HELP':
                show_help()
                continue
            elif new_item == 'SHOW':
                show_list(shopping_list)
                continue
            add_to_list(shopping_list, new_item)

        show_list(shopping_list)

Moderator edited: Added markdown so the code renders properly in the forums.

Jennifer Nordell
seal-mask
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher

Hi there! Again, I believe it to be that you've altered a line that was there originally. Take a look at the first part of the original code:

show_help()

# make a list to hold onto our items
shopping_list = []

while True:
    # ask for new items
    new_item = input("> "

Where the original code has just show_help, you've changed it to def show_help():, which is not a call to the function but rather the beginning of a second declaration of a function inside the the new main function. Then under that, you indented everything again, which would have been correct had that been a definition of a new function.

The easiest way to have completed this challenge was to type def main(): on line 22 and then go down and indent exactly once on every single line thereafter. Here's what my main function looked like when done:

def main():  
    show_help()

# make a list to hold onto our items
    shopping_list = []

    while True:
    # ask for new items
        new_item = input("> ")

    # be able to quit the app
        if new_item == 'DONE':
            break
        elif new_item == 'HELP':
            show_help()
            continue
        elif new_item == 'SHOW':
            show_list(shopping_list)
            continue
        add_to_list(shopping_list, new_item)

    show_list(shopping_list)

Hope this helps! :sparkles: