Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Michael Glur-Zoucha
Michael Glur-Zoucha
9,499 Points

I'm having a hard time with these getters and setters. Not sure how close I am with this, but this is all I have so far.

Can anyone help me with this setter question?

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

    set major (major) {
      level ();
      if (level = 'Senior' || 'Junior') {
        this._major = major;
        }
      else if (level = 'Freshman' || 'Sophomore') {
        this._major = 'None';
        }
    }
}

var student = new Student(3.9, 60);

1 Answer

Brian Jensen
seal-mask
STAFF
.a{fill-rule:evenodd;}techdegree seal-36
Brian Jensen
Treehouse Staff

You're pretty close Michael Glur-Zoucha!

It looks like in your setters conditionals you're using an assignment operator instead of an equality operator. Also, you will need to use this. to access the getter method. :thumbsup:

Michael Glur-Zoucha
Michael Glur-Zoucha
9,499 Points

I'm so sorry, but I'm still not getting it. This is where I'm at now:

set major (major) { Student.level; if (this.level == 'Senior' || 'Junior') { this._major = major; } else if (this.level == 'Freshman' || 'Sophomore') { this._major = 'None'; } }

Is this what you mean?

Brian Jensen
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Brian Jensen
Treehouse Staff

Much closer Michael Glur-Zoucha :star:

This is what it needs to be:

set major(major) {
  if (this.level == 'Senior' || this.level == 'Junior') {
    this._major = major;
  } else if (this.level == 'Freshman' || this.level == 'Sophomore') {
    this._major = 'None';
  }
}