Illegal Argument Exception

Question

Hi, I have completed the task of normalizeDiscountCode function and when i run the code it shows "Oops! It looks like Task 1 is no longer passing ". I am not able figure out what went wrong. Can someone take a look and tell me where i went wrong. Thanks

Order.java

public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  private String normalizeDiscountCode(String discountCode){
      String upperDiscountCode =discountCode.toUpperCase();
      String compareString ="$ABCDEFGHIJKLMNOPQRSTUVWXYZ";
      int result = 0;

      for(char i:compareString.toCharArray()){
        for(char j:upperDiscountCode.toCharArray()){
          if(j == i);{
            result ++;  
          }        
        } 
      }
      if(result == upperDiscountCode.length()){
        return upperDiscountCode;   
      }
      else {
        throw new IllegalArgumentException("Invalid discount code");
      } 
  }

  public void applyDiscountCode(String discountCode) {
    String upperDiscountCode=normalizeDiscountCode(discountCode);
    this.discountCode = upperDiscountCode;
 }
}

Example.java

public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

Answer 1 · 2018-03-20T23:59:39Z

March 20, 2018 11:59pm

The reason you get the error is because of this loop:

for(char i:compareString.toCharArray()){
    for(char j:upperDiscountCode.toCharArray()){
        if(j == i);{
            result ++;  
        }        
    } 
}

The outermost loop will run for every char in compareString... which will make it run 27 times. This makes result equal to 81 if upperDiscountCode is ABC. This causes the program to catch tIllegalArgumentException because upperDiscountCode.length() isn't equal to 81:

if(result == upperDiscountCode.length()){
        return upperDiscountCode;   
      }
      else {
        throw new IllegalArgumentException("Invalid discount code");
      }

Welcome to the Treehouse Community

Looking to learn something new?

amitha catherine

amitha catherine

Illegal Argument Exception

amitha catherine

amitha catherine

1 Answer

Sigurd Melsom

Sigurd Melsom

amitha catherine

amitha catherine