Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialTrung Bui Duc
1,580 PointsI cannot see what's wrong here -ScrabblePlayer
Hi, Could you please point out the errors in this code? I would like to know why it's not working.
public class ScrabblePlayer {
// A String representing all of the tiles that this player has
private String tiles;
public ScrabblePlayer() {
tiles = "";
}
public String getTiles() {
return tiles;
}
public void addTile(char tile) {
tiles += tile;
}
public boolean hasTile(char tile) {
return tiles.indexOf(tile) != -1;
}
public int getCountOfLetter(char letter) {
int hit = 0;
for(char a : tiles.toCharArray()) {
if(tiles.indexOf(a) == letter) {
++hit;
}
}
return hit;
}
}
// This code is here for example purposes only
public class Example {
public static void main(String[] args) {
ScrabblePlayer player1 = new ScrabblePlayer();
player1.addTile('d');
player1.addTile('d');
player1.addTile('p');
player1.addTile('e');
player1.addTile('l');
player1.addTile('u');
ScrabblePlayer player2 = new ScrabblePlayer();
player2.addTile('z');
player2.addTile('z');
player2.addTile('y');
player2.addTile('f');
player2.addTile('u');
player2.addTile('z');
int count = 0;
// This would set count to 1 because player1 has 1 'p' tile in her collection of tiles
count = player1.getCountOfLetter('p');
// This would set count to 2 because player1 has 2 'd'' tiles in her collection of tiles
count = player1.getCountOfLetter('d');
// This would set 0, because there isn't an 'a' tile in player1's tiles
count = player1.getCountOfLetter('a');
// This will return 3 because player2 has 3 'z' tiles in his collection of tiles
count = player2.getCountOfLetter('z');
// This will return 1 because player2 has 1 'f' tiles in his collection of tiles
count = player2.getCountOfLetter('f');
}
}
1 Answer
samiff
31,206 PointsHi Trung,
You are very close to solving the challenge, but are making a mistake with if(tiles.indexOf(a) == letter)
. You don't need to use indexOf, because you've already converted the private String tiles
to an array of characters which you are iterating over. Because you will iterate over all of these characters, you can simply check if each of those tiles matches the passed in char letter
parameter.
int count = 0;
for (char tile : this.tiles.toCharArray()) {
if (tile == letter) count++;
}
return count;
Trung Bui Duc
1,580 PointsTrung Bui Duc
1,580 PointsHi Samiff,
Thank you for answer, I have managed to solve this problem. I should have known that indexOf() was unnecessary :)
Best regards, Trung