Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialMatija Skriljak
3,338 PointsHow to make this work??? With my code editor and 2 different solutions task is accomplished, but not here, again!!
I have two solutions, both do the work, but can't work with that test???
//Select the navigation
var navigation = document.getElementById("navigation");
//Select all listItems from the navigation
var listItems = navigation.children;
//When a navigation link is pressed
var linkListener = function() {
console.log("Listener is clicked!");
}
var bindEventsToLinks = function(listItem) {
//Select the anchor
var anchor = listItem;
//Bind the linkListener to the anchor element (a)
anchor.onclick = linkListener;
}
for(var i = 0; i < listItems.length ; i++) {
bindEventsToLinks(listItems[i]);
}
<!DOCTYPE html>
<html>
<head></head>
<body>
<ul id="navigation">
<li>
<a href="#home">Home</a>
</li>
<li>
<a href="#about">About</a>
</li>
<li>
<a href="#contact">Contact</a>
</li>
</ul>
<p>A few of my favourite things:</p>
<ul>
<li>
Rain drops on roses
</li>
<li>
Whiskers on kittens
</li>
<li>
Brown paper packages wrapped up with string
</li>
</ul>
<script src="app.js"></script>
</body>
</html>
2 Answers
Henrik Christensen
Python Web Development Techdegree Student 38,322 PointsYou need to use the .querySelector on line 14 like this:
var anchor = listItem.querySelector("a");
Tonye Jack
Full Stack JavaScript Techdegree Student 12,469 PointsSince its not a default click element you can just bind the click handler to the list item with
var anchor = listItem.querySelector("a");
anchor.bind('click', linkListener);
best practice to query the selector for the element to ensure your adding the listener to the right element
like the above answer