How to get the proper count with a for loop

Question

The program says that I am returning a count of 0 when it expects a count of 1. Any help is appreciated. Thanks!

ScrabblePlayer.java

public class ScrabblePlayer {
  // A String representing all of the tiles that this player has
  private String tiles;

  public ScrabblePlayer() {
   // tiles = "";
    this.tiles = tiles;

  }

  public String getTiles() {
    return tiles;
  }

  public void addTile(char tile) {
    tiles += tile;
  }

  public boolean hasTile(char tile) {
    return tiles.indexOf(tile) != -1;
  }

  public int getCountOfLetter(char letter){

    int count = 0;

    for (char currentLetter : tiles.toCharArray())
    {

      if (tiles.indexOf(letter) == 0)
      {
        count++;
      }
    }

    return count;
  }
}

Example.java

// This code is here for example purposes only
public class Example {

  public static void main(String[] args) {
    ScrabblePlayer player1 = new ScrabblePlayer();
    player1.addTile('d');
    player1.addTile('d');
    player1.addTile('p');
    player1.addTile('e');
    player1.addTile('l');
    player1.addTile('u');

    ScrabblePlayer player2 = new ScrabblePlayer();
    player2.addTile('z');
    player2.addTile('z');
    player2.addTile('y');
    player2.addTile('f');
    player2.addTile('u');
    player2.addTile('z');

    int count = 0;
    // This would set count to 1 because player1 has 1 'p' tile in her collection of tiles
    count = player1.getCountOfLetter('p');
    // This would set count to 2 because player1 has 2 'd'' tiles in her collection of tiles
    count = player1.getCountOfLetter('d');
    // This would set 0, because there isn't an 'a' tile in player1's tiles
    count = player1.getCountOfLetter('a');

    // This will return 3 because player2 has 3 'z' tiles in his collection of tiles
    count = player2.getCountOfLetter('z');
    // This will return 1 because player2 has 1 'f' tiles in his collection of tiles
    count = player2.getCountOfLetter('f');
  }
}

Answer 1 · 2018-01-05T23:55:54Z

January 5, 2018 11:55pm

Shouldn't be something like this?

 public ScrabblePlayer() {
    this.tiles = ""; 
  }

The way that you're doing you will have to send a String as a parameter when you create a new ScrabblePlayer, and you aren't doing that.

And in getCountOfLetter shouldn't be something like this?

if (tiles.indexOf(letter) != -1)
      {
        count++;
      }

tiles.indexOf(letter) will return the position of the letter in the array, it won't be always 0. So if the letter isn't there will return -1, so just check if isn't -1 to add to count!

Welcome to the Treehouse Community

Looking to learn something new?

Curtis Wyman

Curtis Wyman

How to get the proper count with a for loop

1 Answer

Daiane Silva

Daiane Silva