Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialRomain Trost
1,811 PointsHi. Can someone please help me with my exception here?
1st task: For this first task, create a new private method named normalizeDiscountCode. It should take the discount code that is passed into the method and return the uppercase version. Call it from the current applyDiscountCode method and set this.discountCode to the result.
2nd task: In the normalizeDiscountCode verify that only letters or the $ character are used. If any other character is used, throw a IllegalArgumentException with the message Invalid discount code.
For some reason my code tells me that task one is no longer correct whereas when i go back to task one and click "check work" it tells me that my code is valid and puts me back onto task 2. Any help would be much appreciated.
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
private String normalizeDiscountCode(String discountCode) {
String upperDiscountCode = discountCode.toUpperCase();
String acceptedDiscountCode = "ABCDEFGHIJKLMNOPQRSTUVWXYZ$";
for (char i : discountCode.toCharArray()) {
for (char j : acceptedDiscountCode.toCharArray()) {
if (i == j) {
return upperDiscountCode;
}
else {
throw new IllegalArgumentException("Invalid discount code");
}
}
}
return upperDiscountCode;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
String upperDiscountCode = normalizeDiscountCode(discountCode);
this.discountCode = upperDiscountCode;
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
1 Answer
Craig Dennis
Treehouse TeacherHmmm... why the nested for loops? return
will exit out the method immediately.
Have you seen Character.isLetter ?
(Hope that hint helps!)
Romain Trost
1,811 PointsRomain Trost
1,811 PointsThanks!! I got it :)