Help with challenge

Question

I managed to do all the to dos I believe. However my code is no where near descent. I feel that there are many things that could be done clearer and more efficiently. I hope someone here can help me understand it a little better.

Prompter class

package com.teamtreehouse;

import java.io.*; import java.nio.file.Files; import java.nio.file.Path; import java.nio.file.Paths; import java.util.ArrayList; import java.util.HashSet; import java.util.List; import java.util.Set;

public class Prompter { private BufferedReader mReader; private Set<String> mCensoredWords;

public Prompter() {
    mReader = new BufferedReader(new InputStreamReader(System.in));
    loadCensoredWords();
}

private void loadCensoredWords() {
    mCensoredWords = new HashSet<String>();
    Path file = Paths.get("resources", "censored_words.txt");
    List<String> words = null;
    try {
        words = Files.readAllLines(file);
    } catch (IOException e) {
        System.out.println("Couldn't load censored words");
        e.printStackTrace();
    }
    mCensoredWords.addAll(words);
}

public void run(Template tmpl) {
    List<String> results = null;
    try {
        results = promptForWords(tmpl);
        System.out.printf("Your TreeStory:%n%n%s",tmpl.render(results));

    } catch (IOException e) {
        System.out.println("There was a problem prompting for words");
        e.printStackTrace();
        System.exit(0);

    }
    // TODO:csd - Print out the results that were gathered here by rendering the template

}

/**
 * Prompts user for each of the blanks
 *
 * @param tmpl The compiled template
 * @return
 * @throws IOException
 */
public List<String> promptForWords(Template tmpl) throws IOException {
    List<String> words = new ArrayList<String>();
    for (String phrase : tmpl.getPlaceHolders()) {
        String word = promptForWord(phrase);
        words.add(word);
    }
    return words;
}
public String promptForStory(String story) throws IOException {
    System.out.println("Please enter a Story that Follow this pattern. \n" +  story + " \n");
    String userStory = mReader.readLine();
    return userStory;
}


/**
 * Prompts the user for the answer to the fill in the blank.  Value is guaranteed to be not in the censored words list.
 *
 * @param phrase The word that the user should be prompted.  eg: adjective, proper noun, name
 * @return What the user responded
 */
public String promptForWord(String phrase) throws IOException {
    // TODO:csd - Prompt the user for the response to the phrase, make sure the word is censored, loop until you get a good response. DONE
    String userWord;
    do {
        System.out.printf("Please enter a valid:  %s ", phrase);
        userWord = mReader.readLine();
        if(mCensoredWords.contains(userWord)) {
            System.out.print("That is not a nice word to use. \n");
        }
    } while (mCensoredWords.contains(userWord));

    return userWord;
}

}

Template package com.teamtreehouse;

import java.util.ArrayList; import java.util.List; import java.util.regex.Matcher; import java.util.regex.Pattern;

public class Template { /** * The string format that is waiting to receive values */ private String mCompiled; private List<String> mPlaceholders;

/**
 * @param text A template with double underscored surrounded placeholders. eg: Hello __name__!
 */
public Template(String text) {
    // Match on double underscore surrounded words, like __name__ or __proper noun__
    Pattern pattern = Pattern.compile("__([^__]+)__");
    Matcher matcher = pattern.matcher(text);
    mPlaceholders = new ArrayList<String>();
    while (matcher.find()) {
        String label = matcher.group(1);
        mPlaceholders.add(label);
    }
    mCompiled = matcher.replaceAll("%s");
}


/**
 * @return Ordered names of placeholders in the template
 */
public List<String> getPlaceHolders() {
    return mPlaceholders;
}


/**
 * Given a list of values, replaces the fill in the blanks in order.
 *
 * @param values The replacements for the fill in the blank
 * @return The filled out TreeStory
 */
public String render(List<String> values) {
    // String.format accepts the templates and Object... (a variable amount of objects)
    return String.format(mCompiled, values.toArray());
}

}

Main package com.teamtreehouse;

import java.io.IOException; import java.util.Arrays; import java.util.List;

public class Main {

public static void main(String[] args) {
// write your code here
    // TODO:csd - Instantiate a new Prompter object and prompt for the story template DONE
    //List<String> fakeResults = Arrays.asList("friend", "talented", "java programmer", "high five");
    Prompter userStory = new Prompter();
    String userInput;

    // TODO:csd - Use the prompter object to have it do the prompting, censoring and outputting.  Call Prompter.run
    String story = "Thanks __name__ for helping me out.  You are really a __adjective__ __noun__ and I owe you a __noun__.";
    try {
        userInput = userStory.promptForStory(story);
        System.out.println("Your Story: \n" + userInput);
       // userStory.promptForWord("verb");
        Template tmpl = new Template(userInput);
        userStory.run(tmpl);
        // TODO:csd - This should really happen in the Prompter.run method, let's get these implementation details out of the main method

    } catch (IOException e) {
        e.printStackTrace();
    }







}

}

Welcome to the Treehouse Community

Looking to learn something new?

Danilo ANRIA

Danilo ANRIA

Help with challenge