Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trial
Martin Torres
10,353 PointsHelp, I've been trying to solve this but i can't and I don't know why
The code Prompts for the new Story and shows it, i don't know why it doesn't work
package com.teamtreehouse;
import java.io.IOException;
public class Main {
public static void main(String[] args) {
// write your code here
Prompter prompter = new Prompter();
String story = null;
try {
story = prompter.story( );
} catch (IOException e) {
e.printStackTrace();
}
Template tmpl = new Template(story);
try {
prompter.promptForWords(tmpl);
} catch (IOException e) {
e.printStackTrace();
}
//List<String> fakeResults = Arrays.asList("friend", "talented", "java programmer", "high five");
String results = tmpl.render(prompter.run(tmpl));
System.out.println("Your TreeStory");
System.out.printf("Your TreeStory:%n%n%s", results);
}
}
package com.teamtreehouse;
import java.io.*;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
class Prompter {
private BufferedReader mReader;
private Set<String> mCensoredWords;
public Prompter() {
mReader = new BufferedReader(new InputStreamReader(System.in));
loadCensoredWords();
}
private void loadCensoredWords() {
mCensoredWords = new HashSet<String>();
Path file = Paths.get("resources", "censored_words.txt");
List<String> words = null;
try {
words = Files.readAllLines(file);
} catch (IOException e) {
System.out.println("Couldn't load censored words");
e.printStackTrace();
}
mCensoredWords.addAll(words);
}
public String story() throws IOException {
System.out.println("Write a new story with double underscores between the words to prompt");
String story = mReader.readLine();
return story;
}
public List<String> run(Template tmpl) {
List<String> results = null;
try {
results = promptForWords(tmpl);
} catch (IOException e) {
System.out.println("There was a problem prompting for words");
e.printStackTrace();
System.exit(0);
}
for(String result: results){
System.out.println(result);
}
return results;
}
/**
* Prompts user for each of the blanks
*
* @param tmpl The compiled template
* @return
* @throws IOException
*/
public List<String> promptForWords(Template tmpl) throws IOException {
List<String> words = new ArrayList<String>();
for (String phrase : tmpl.getPlaceHolders()) {
String word = promptForWord(phrase);
words.add(word);
}
return words;
}
/**
* Prompts the user for the answer to the fill in the blank. Value is guaranteed to be not in the censored words list.
*
* @param phrase The word that the user should be prompted. eg: adjective, proper noun, name
* @return What the user responded
*/
public String promptForWord(String phrase) throws IOException {
System.out.printf("Type in a word for %s %n", phrase);
String userWord = null;
try {
userWord = mReader.readLine();
} catch (IOException e) {
e.printStackTrace();
}
if (mCensoredWords == null || userWord == null){
System.out.println(userWord);
System.out.println(mCensoredWords);
System.out.println("one of these is null!");
}
while (mCensoredWords.contains(userWord != null ? userWord.toLowerCase() : null)) {
System.out.printf("You have chosen a word that is not allowed! %n try again please. . . ");
userWord = mReader.readLine();
}
return userWord;
}
}
# This is essentially what I am testing
1. The user is prompted for a new string template (the one with the double underscores in it).
a. The prompter class has a new method that prompts for the story template, and that method is called.
2. The user is then prompted for each word that has been double underscored.
a. The answer is checked to see if it is contained in the censored words.
User is continually prompted until they enter a valid word
3. The user is presented with the completed story
1 Answer
Alexander Nikiforov
Java Web Development Techdegree Graduate 22,175 PointsTwo main problems exist with your code, both in Main and in Prompter
Main class Problem
You call promptForWords method TWICE, once in prompter.run() and second time directly. You confuse tester this way:
package com.teamtreehouse;
import java.io.IOException;
public class Main {
public static void main(String[] args) {
// write your code here
Prompter prompter = new Prompter();
String story = null;
try {
story = prompter.story( );
} catch (IOException e) {
e.printStackTrace();
}
Template tmpl = new Template(story);
// removing this block completely ...
// try {
// prompter.promptForWords(tmpl);
// } catch (IOException e) {
// e.printStackTrace();
// }
//List<String> fakeResults = Arrays.asList("friend", "talented", "java programmer", "high five");
String results = tmpl.render(prompter.run(tmpl));
System.out.println("Your TreeStory");
System.out.printf("Your TreeStory:%n%n%s", results);
}
}
Prompter class problem
In the Prompter.promptForWord you check for null. It is not bad checking for null. But unfortunately it will not let you pass the challenge. I don't know why and how. I don't know how Testing files from Craig look like.
So removing null checks should let you pass
public String promptForWord(String phrase) throws IOException {
System.out.printf("Type in a word for %s %n", phrase);
String userWord = null;
try {
userWord = mReader.readLine();
} catch (IOException e) {
e.printStackTrace();
}
// removing this
// if (mCensoredWords == null || userWord == null){
// System.out.println(userWord);
// System.out.println(mCensoredWords);
// System.out.println("one of these is null!");
// }
// refactoring this
while (mCensoredWords.contains(userWord)) {
System.out.printf("You have chosen a word that is not allowed! %n try again please. . . ");
userWord = mReader.readLine();
}
return userWord;
}